After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 110999 - RFE: The Open/Copy Link items on the context popup should be the first ones
RFE: The Open/Copy Link items on the context popup should be the first ones
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: High normal
: ---
Assigned To: Havoc Pennington
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-04-17 06:02 UTC by Mariano Suárez-Alvarez
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Move Open/Link popup items to the top (1.98 KB, patch)
2003-04-17 06:03 UTC, Mariano Suárez-Alvarez
none Details | Review

Description Mariano Suárez-Alvarez 2003-04-17 06:02:51 UTC
One slightly annoying thing with right-clicking on a link is that the menu
items dealing with the link are placed at the bottom of the menu, when in
fact I, at least, exclusively right-click in order to deal with links...

The following patch puts the ``Open Link'' and ``Copy Link Address'' items
(I can't believe the HIG chooses to capitalize menu items like that...) at
the top of the pop---separated from the other iters by a separator---and
only when the right click was on an actual link.
Comment 1 Mariano Suárez-Alvarez 2003-04-17 06:03:42 UTC
Created attachment 15793 [details] [review]
Move Open/Link popup items to the top
Comment 2 Kjartan Maraas 2003-04-22 15:30:06 UTC
Upping priority because of patch.
Comment 3 Havoc Pennington 2003-04-22 15:39:44 UTC
Menu items shouldn't come and go, only be enabled/disabled. 
Otherwise you can't learn where they are.

It isn't obvious to me that these items are more common 
than new window, new tab, and copy/paste - though they clearly are 
more common than the profile/IM stuff so should be above those.
Comment 4 Mariano Suárez-Alvarez 2003-04-22 21:33:52 UTC
How can you learn what you need to do to activate a particular
disabled menu item? 

Of course, if you can't see it at all, the question does not even
present itself, I know, but ``popup menus are used primarily by
intermediate and advanced users,'' and terminals do provide visual
indication that hovering over a link is a significat event. Also,
right-click-to-get-contextual-menu is, along with double-click-to-act,
is one of the main gui idioms, isn't it?

The HIG suggest that menu items on a popup be ordered with 
the ``default action for object'' first. On a link, the default action
is Open Link, IMO. It does say, too, that one should not ``add or
remove individual menu items while the application is running,'' but
``make them insensitive instead,'' but this cannot (and most probably
should not) be applied systematically to popups---think of how glade
would be if it never added/removed its popup...

That said, feel free to close the bug and move on :)
Comment 5 Calum Benson 2003-04-24 18:13:57 UTC
Just a note on the HIG guidelines here... can't remember exactly what
it says specifically about popup menus, but the idea is that each
'object' is considered to have its own popup menu.  (In fact, each
state of each object could be considered to have its own popup menu,
but not many apps go that far).

So yes, of course you shouldn't get the same massive popup menu
everywhere in Glade with lots of items disabled.  But you *should* get
the same popup menu every time you click on a button, for example,
possibly with a couple of items greyed out that don't apply to that
*particular* button.

Learning how to make a particular menu item active is a problem
everywhere, not just in popups... personally I'd like to see
information about how to make an item active added to every
insensitive item's tooltip, but menus don't generally have tooltips at
the moment...
Comment 6 Havoc Pennington 2003-04-24 18:59:51 UTC
Ah, OK. So by that guideline it seems reasonable to move those items. 
Comment 7 Mariano Suárez-Alvarez 2003-06-24 23:26:54 UTC
Is this to be commited, then?
Comment 8 Havoc Pennington 2003-06-24 23:47:31 UTC
Yes, please feel free to commit this (with ChangeLog entry
of course)
Comment 9 Mariano Suárez-Alvarez 2003-06-29 23:08:32 UTC
Done.