After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 110834 - [PATCH] - more precise props API
[PATCH] - more precise props API
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other other
: Urgent normal
: 0.6.x
Assigned To: Christian Fredrik Kalager Schaller
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-04-15 10:22 UTC by Joshua N Pritikin
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch for gstprops.c (507 bytes, patch)
2003-04-15 10:23 UTC, Joshua N Pritikin 		none Details | Review

Description Joshua N Pritikin 2003-04-15 10:22:02 UTC 
gst_props_has_property should g_assert(props) or just return FALSE.  The
attached patch makes it return FALSE.
Comment 1 Joshua N Pritikin 2003-04-15 10:23:57 UTC 
Created attachment 15732 [details] [review]
proposed patch for gstprops.c
Comment 2 Benjamin Otte (Company) 2003-04-16 14:21:26 UTC 
Wouldn't it be more useful to use a g_return_val_if_fail there?
So the programmer actually knows he has made a mistake?
Comment 3 Benjamin Otte (Company) 2003-05-14 00:20:18 UTC 
Just looked at it and gst_props_get_entry checks for props not being
empty. So this is not a bug.

Closing it.