Created attachment 15638 [details] [review]
fix

Bah, that's evil... Most plugins assume we handle audio in the
arch-native form, so if a specific plugins only wants one endian sort,
then it should do conversion internally. Long-term, separate filter
elements might come in handy here, but a short-term solution is to
just do it inside wavenc. Patch attached.

Created attachment 15665 [details] [review]
how about this?

Created attachment 15666 [details] [review]
use copy_on_write() instead

Middle patch applied, because it's easiest.

Real issue here is that we would want either a filter plugin that's
automatically inserted, or we'd want some core functions to copy a
buffer (everything *except the actual data*!), something like
gst_buffer_copy_empty(). Combining that with
gst_data_need_copy_on_write() would fix this much nicer, but that's
all something for HEAD + long-term, not for 0.6.1.

Created attachment 16353 [details] [review]
endian fix (not mine)

I'm using this patch on my ppc box; it's required to get wavparse
working.  The patch originated from BBB or Company, I believe; I
apologize to the author for not remembering their name. :)

Assigning this to Ronald as the patch should be applied before 0.6.2

This patch originally covered wavenc, not wavparse. Both patches are
already on 0.6.x CVS. HEAD has different ideas (ask Benjamin for details).

So yeah, we don't need this. :).