GNOME Bugzilla – Bug 110171
[0.6.1] My Diffs review for 0.6.1 from HEAD
Last modified: 2004-12-22 21:47:04 UTC
Here we go... links to the diffs who need reviewing ... Basically API additions, code esthetical cleanup, and one api modification which i m almost 99% sure nobody use. gst-gconf stuff http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins/gst-libs/gst/gconf/gconf.c.diff?r1=1.9&r2=1.10 http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins/gst-libs/gst/gconf/gconf.h.diff?r1=1.4&r2=1.5 libgstplay stuff http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins/gst-libs/gst/play/playpipelines.c.diff?r1=1.5&r2=1.9 http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins/gst-libs/gst/play/play.h.diff?r1=1.4&r2=1.8 http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins/gst-libs/gst/play/play.c.diff?r1=1.8&r2=1.14
gconf stuff is ok, but we're still not sure whether API additions are allowed. I'd say they are, but some people disagree. Let's ask the Gnome guys to be sure. The other stuff is ABI incompatible so I'd need to double check for real breakage. In the worst case, we can decide to use libtool version incrementing here. Either way, I hope it cna go in, it wouldn't be good if gst-player can't run on 0.6.1.
http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins/gconf/gstreamer.schemas.diff?r1=1.8&r2=1.9 I'm guessing you need this one too (default vis. element).
GConf stuff applied to 0.6.1. libgstplay is awaiting some more testing.
According to Julien (dolphy), gst-player-0.5.0 (compiled for 0.6.0) works with the above libgstplay patches applied to the 0.6.x branch, which means that these changes can go in (they don't break it).
libgstplay applied to 0.6.1 too.