After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 109529 - No error message when an invalid soundfile is selected.
No error message when an invalid soundfile is selected.
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sound
2.0.x
Other Linux
: High normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-03-30 09:39 UTC by Balamurali Viswanathan
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for this bug (1.96 KB, patch)
2003-03-30 09:41 UTC, Balamurali Viswanathan 		none Details | Review

Description Balamurali Viswanathan 2003-03-30 09:39:49 UTC 
Steps to reproduce
1.Invoke sound Capplet by selecting 'Application->Desktop
Preferences->Sound'.
2. The 'Sound Preferences' window will be invoked.
3. Select 'Sound Event' Tab.
4. Select any sound event say 'Player wins!' from 'Gnet'.
5. Click on 'Browse' button.
6. Select any invalid sound file or any directory.
7. The invalid sound file or directory is displayed as the sound file to be
played.
No error message is shown.

Attaching a patch the check the mime type of the selected file and if it
not "audio/x-wav", an error dialog is shown. Thanks.
Comment 1 Balamurali Viswanathan 2003-03-30 09:41:09 UTC 
Created attachment 15306 [details] [review]
Patch for this bug
Comment 2 Kjartan Maraas 2003-04-22 23:09:13 UTC 
Adding keywords upping pri.
Comment 3 Kjartan Maraas 2003-04-29 22:01:12 UTC 
Does audio/x-wav cover all the possible sound formats that are relevant here?
Comment 4 Balamurali Viswanathan 2003-05-01 09:33:33 UTC 
Only wav files can be associated with the events and thats why I am
checking only for audio/x-wav, do I need to check for other formats
too. Thanks.
Comment 5 Kjartan Maraas 2003-05-03 22:55:42 UTC 
No, I think .wav is the only supported format as of now.
Comment 6 Andrew Sobala 2003-05-14 17:06:37 UTC 
Can this be reviewed, then?
Comment 7 Balamurali Viswanathan 2003-07-04 06:46:50 UTC 
Is this patch ok to commit ?
Comment 8 Kjartan Maraas 2003-07-04 18:51:48 UTC 
Looks ok to me. Only for HEAD though because of the string changes. I
wonder if we should say "We are going to support other formats for
sound events in the future."?

I'm not really the person to say yes or no for control-center though :)
Comment 9 Jody Goldberg 2003-07-30 13:21:58 UTC 
Does it truely need to be limited to just wav files ?
or could we be more generic and allow 'audio/*' ?
Comment 10 Balamurali Viswanathan 2003-07-30 15:22:53 UTC 
Jody, Presently only wav formats are supported, thats why I am
checking for only audio/x-wav.
Comment 11 Jody Goldberg 2003-07-30 16:35:06 UTC 
ok.
Then please apply.
Comment 12 Jonathan Blandford 2003-07-31 18:37:18 UTC 
Fixed in CVS.