After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 109048 - [0.6.1] gst-plugins makes the assumption that sys/io.h exists on all glibc archs
[0.6.1] gst-plugins makes the assumption that sys/io.h exists on all glibc archs
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.6.0
Other Linux
: Normal normal
: 0.6.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-03-23 23:54 UTC by Andres Salomon
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
header include patch (556 bytes, patch)
2003-03-23 23:58 UTC, Andres Salomon
none Details | Review

Description Andres Salomon 2003-03-23 23:54:18 UTC
The qcam driver in gst-plugins (sys/qcam/qcam-{os,Linux}.c) include
<sys/io.h>, which doesn't exist under all archs.  For example, I'm using
ppc, and there is no /usr/include/sys/io.h under glibc 2.3.1.  I'm told
that there is also no sys/io.h for the following architectures: mips, hppa,
m68k and s390.  I think what is meant to be included is <asm/io.h>; this is
available for all archs supported by linux.
Comment 1 Andres Salomon 2003-03-23 23:58:00 UTC
Created attachment 15174 [details] [review]
header include patch
Comment 2 Ronald Bultje 2003-04-04 19:33:01 UTC
Fixed in HEAD. Awaiting 0.6.1 approval.
Comment 3 David Schleef 2003-04-04 22:26:41 UTC
Someone please put this plugin out of its misery.  Direct I/O access
has been out of fashion for about 8 years.

The <sys/io.h> -> <asm/io.h> patch is technically incorrect, but
mostly irrelevant.

http://cvs.sf.net/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins/configure.ac.diff?r1=1.246&r2=1.247
Comment 4 David Schleef 2003-04-05 01:31:38 UTC
I'm reverting the asm/io.h -> sys/io.h change, since it breaks the build:

gcc -DHAVE_CONFIG_H -I. -I. -I../.. -O2 -I../../gst-libs
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -pthread
-I/home/ds/gst/cvs/gstreamer -I/home/ds/gst/cvs/gstreamer/libs
-I../..//home/ds/gst/cvs/gstreamer/.
-I../..//home/ds/gst/cvs/gstreamer/./libs -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/libxml2
-I/usr/include/libxml2/libxml -DGST_DISABLE_DEPRECATED -g -Wall
-Werror -g -O2 -c qcam-lib.c -MT libgstqcam_la-qcam-lib.lo -MD -MP -MF
.deps/libgstqcam_la-qcam-lib.TPlo  -fPIC -DPIC -o
libgstqcam_la-qcam-lib.lo
cc1: warnings being treated as errors
In file included from qcam-lib.c:47:
qcam-os.c: In function `enable_ports':
qcam-os.c:58: warning: implicit declaration of function `ioperm'
make[3]: *** [libgstqcam_la-qcam-lib.lo] Fehler 1
make[3]: Leaving directory `/home/ds/gst/cvs/gst-plugins/sys/qcam'
make[2]: *** [all-recursive] Fehler 1
make[2]: Leaving directory `/home/ds/gst/cvs/gst-plugins/sys'
make[1]: *** [all-recursive] Fehler 1
make[1]: Leaving directory `/home/ds/gst/cvs/gst-plugins'
make: *** [all] Fehler 2
Comment 5 David Schleef 2003-04-05 04:27:05 UTC
er, I meant the "sys/io.h -> asm/io.h" change.

sys/io.h is correct
Comment 6 David Schleef 2003-04-05 20:58:56 UTC
I fscked up the patch.  Also apply this to 0.6.1

http://cvs.sf.net/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins/configure.ac.diff?r1=1.247&r2=1.248
Comment 7 Ronald Bultje 2003-04-07 17:09:26 UTC
Fixed in 0.6.1 CVS.