GNOME Bugzilla – Bug 108489
Some headers do not appear by requiring all headers
Last modified: 2006-06-18 05:09:44 UTC
Pan 0.13.91 With shortcut 'H' or by menu, these headers do not appear in body pane: - Mime-Version, - Content-Type and charset, - Content-Transfer-Encoding
Heh, Chris noticed this yesterday. I wondered how long it would be until someone filed a bug report on this. fejj: this is a regression that I've apparently introduced. I remember that there were multiple ways of extracting headers from GMime; one allowed _all_ headers, including mime, to be pulled; others didn't. Could you please look at pan/pan/text.c lines 689-694 and see what you think? What should the code look like instead?
g_mime_object_get_headers() called on the message object *should* get you all you need.
Ah, I was using foreach() on the message->headers but not drilling down to see if message->mime_part->headers existed too. Adding an if (message->mime_part) { foreach m->m->h } does the trick. Fixed in CVS: http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=text.c&rev1=1.350&rev2=1.351&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan&command=DIFF_FRAMESET&file=ANNOUNCE.html&rev1=1.88&rev2=1.89&root=/cvs/gnome