After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 108132 - Make gstmm a little more compilable (incomplete)
Make gstmm a little more compilable (incomplete)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstmm
git master
Other other
: Normal normal
: 0.6.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 108514
Blocks:
 
 
Reported: 2003-03-11 21:57 UTC by Peter N. Lundblad
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
First patch. (47.03 KB, patch)
2003-03-11 21:59 UTC, Peter N. Lundblad
none Details | Review
New file. (1.05 KB, patch)
2003-03-11 22:03 UTC, Peter N. Lundblad
none Details | Review
New file. caps.hg (1.10 KB, text/plain)
2003-03-11 22:05 UTC, Peter N. Lundblad
  Details
New file. clock.hg (1.05 KB, text/plain)
2003-03-11 22:06 UTC, Peter N. Lundblad
  Details
New file. event.hg (1.40 KB, text/plain)
2003-03-11 22:08 UTC, Peter N. Lundblad
  Details
New file. event.ccg (950 bytes, text/plain)
2003-03-11 22:09 UTC, Peter N. Lundblad
  Details
New file. pluginfeature.ccg (918 bytes, text/plain)
2003-03-11 22:10 UTC, Peter N. Lundblad
  Details
New file. pluginfeature.hg (1.09 KB, text/plain)
2003-03-11 22:11 UTC, Peter N. Lundblad
  Details
New file. scheduler.hg (1.08 KB, text/plain)
2003-03-11 22:11 UTC, Peter N. Lundblad
  Details

Description Peter N. Lundblad 2003-03-11 21:57:29 UTC
This patch will fix some compilation errors. It is incomplete.
And I know there are errors. Please review.
Comment 1 Peter N. Lundblad 2003-03-11 21:59:13 UTC
Created attachment 14934 [details] [review]
First patch.
Comment 2 Peter N. Lundblad 2003-03-11 22:03:47 UTC
Created attachment 14935 [details] [review]
New file.
Comment 3 Peter N. Lundblad 2003-03-11 22:05:11 UTC
Created attachment 14936 [details]
New file. caps.hg
Comment 4 Peter N. Lundblad 2003-03-11 22:06:27 UTC
Created attachment 14937 [details]
New file. clock.hg
Comment 5 Peter N. Lundblad 2003-03-11 22:08:37 UTC
Created attachment 14938 [details]
New file. event.hg
Comment 6 Peter N. Lundblad 2003-03-11 22:09:06 UTC
Created attachment 14939 [details]
New file. event.ccg
Comment 7 Peter N. Lundblad 2003-03-11 22:10:38 UTC
Created attachment 14940 [details]
New file. pluginfeature.ccg
Comment 8 Peter N. Lundblad 2003-03-11 22:11:08 UTC
Created attachment 14941 [details]
New file. pluginfeature.hg
Comment 9 Peter N. Lundblad 2003-03-11 22:11:59 UTC
Created attachment 14942 [details]
New file. scheduler.hg
Comment 10 Martin Schulze 2003-03-11 23:46:31 UTC
I will look into this tomorrow. Martin.
Comment 11 Martin Schulze 2003-03-12 10:54:17 UTC
I committed "First Patch" along with other changes of my own.

Changes I left out:

_CLASS_GTK_OBJECT -> _CLASS_GOBJECT:
pointer -> Glib::RefPtr<>:
I'd like to try this seperately. But don't have the time right now.

Index: configure.in
! GTKMM_PREFIX=`pkg-config --variable=prefix glibmm-2.0`
Wrong. Build requires gtkmmproc which is part of gtkmm-2.0 not glibmm-2.0.

Index: gst/src/pad.hg
!   _WRAP_METHOD(const GstEventMask* get_event_masks() const,
gst_pad_get_event_masks)
Why not EventMask ?

Index: gst/src/pad.hg
!   _WRAP_METHOD(const GstQueryType* get_query_types() const,
gst_pad_get_query_types)
Why not QueryType ?

Index: gst/src/pad.hg
+ class PadTemplate : Gst::Object {
+  
_CLASS_GTKOBJECT(PadTemplate,GstPadTemplate,GST_PAD_TEMPLATE,Gst::PadTemplate,GstPadTemplate)
  };
I added new files pad_template.{ccg,hg} for this. (Sorry, I wrote them
some time ago and didn't have the time to make them compilable now.)


The change I like most :)

Index: gst/src/pad.hg
!   virtual ButterPool* get_buffer_pool_vfunc() const;
Hm, I must have been very hungry when I wrote this :-)
Comment 12 Christian Meyer 2003-03-12 21:09:16 UTC
I've had a look at your files Peter.
I downloaded them on my local disk but I won't upload them to cvs
until Martin/I has/have fixed the caps-m4 error (see my mail).

event class:
I don't like to have 2 classes in one file. That's IMHO a not-so-nice
feature in C++. Please write ONE file for ONE class.
Please change _CLASS_GTKOBJECT to _CLASS_GOBJECT.
Comment 13 Martin Schulze 2003-03-13 17:11:51 UTC
Re caps-m4 error: This is fixed now. gtkmmproc still doesn't pass
everything because of the outdated gst_methods.defs. We have to
regenerate this file. I'm working on it.
Comment 14 Christian Meyer 2003-03-13 21:42:55 UTC
Thanks Martin.
I don't know how I did that last time. Otherwise I'd tell you.
Comment 15 Martin Schulze 2003-03-14 14:32:44 UTC
The .defs files are up-to-date now. I'll be working on element.hg.
After that we have to make fixes to gstreamer so that the generated
files would compile.
Comment 16 Martin Schulze 2003-03-14 16:38:32 UTC
I added all new files. "make" passes in "gst/src". Next step: Report
and fix gstreamer get_type() madness. However, I won't do this until
tomorrow.

Peter: Thanks for your efforts and sorry for the delay. I think gstmm
is now in a more sane state so that you could work on some of the
currently empty wrappers if you like.
Comment 17 Martin Schulze 2003-03-16 13:31:53 UTC
I reported the missing gst_*_get_type() functions (#108514). Along
with my recent commits, only missing constructors and
Glib::ArrayHandle/ListHandle related problems are stopping gstmm from
compiling, now.
Comment 18 Christian Meyer 2003-03-16 21:21:34 UTC
I've succesfully applied Martin's patches.
I also had to modfify two other files, it works now.
Comment 19 Peter N. Lundblad 2003-03-17 06:51:21 UTC
Thank you, Martin and Christian for sorting these things out. I'l try 
it out tonight. More work will be submitted as new bug reports.
Comment 20 Christian Meyer 2003-03-18 13:51:07 UTC
I meant that the patches didn't make gstreamer non-compilable.
I haven't tried to compile gstmm again, because I don't have gstreamer
0.7 on my machine and hence lack of time.
Maybe I can arrange something to get these changes included in
gstreamer 0.6.1.
Comment 21 Christian Meyer 2003-03-18 13:54:07 UTC
We should open other bug reports for every class which isn't easy to fix .