GNOME Bugzilla – Bug 107967
[PATCH] - Fix for autogen.sh so that args are passed to ./configure
Last modified: 2004-12-22 21:47:04 UTC
On the BRANCH-GSTREAMER-0_6 branch (at least), there is a bug in autogen.sh. It does not pass $CONFIGURE_OPTS to configure and it does not pass any extra command line argument to configure (even though it advertises that it will do so if you pass in no arguments). The former problem ($CONFIGURE_OPTS) shows up if you have a 'disable' file of plugins that should not ever be built -- the corresponding '--disable-foo' argument are not passsed to configure. The following patch fixes both of these problems.
Created attachment 14885 [details] [review] Patch to pass all arguments from autogen.sh to configure
You're supposed to call "./autogen.sh --autogen-argument=bla -- --configure-option-bla=bla..." - note the two dashes between the configure arguments and the autogen arguments. Also see ./autogen.sh --help. ;).
Urgh! That makes it different to most other autogen.sh scripts out there (particularly in GNOME). So there's a good argument to change it for consistency reasons. I had read the output of --help and had not noticed the double dashes there at all until you pointed them out.
I agree with Malcomn on this one. So this patch should be merged before 0.6.1 to both 0.6 branch and head.
We've discussed it, we'd rather not apply it. Being consistent with Gnome is a good thing, but our current build system just works as it does, we can't please everyone. Using two dashes shouldn't be the worst thing in the world. Of course, you can always keep a patched autogen.sh if you really want to. ;-).
So are you just going to ignore the other part of the patch as well (not using the contents of $CONFIG_OPT)?
I think GStreamer is doing the right thing here. '--' is the standard way of separating the arguments to the program you're running from other command-line parameters (Think rm -- - to remove a file called "-"). You are running autogen.sh and passing arguments to that app, not to configure. There is already a mechanism in place to pass arguments to configure. It might not be what you're used to, but it makes perfect sense and I don't see why the behaviour would need to be changed. We have valid reasons for having it like this, because we actually do have REAL autogen.sh arguments because they make sense. As to the other part of the patch, if you think it is valid (don't know what it does), please reattach without the other bits and describe what it does. Can you explain what $CONFIGURE_OPTS is, what it's supposed to do and where it is described ?
Created attachment 15547 [details] [review] Patch to fix autogen.sh
$CONFIGURE_OPT is documented in your autogen.sh file. If the file 'disable' exists, every line in it is appended to a '--disable-' flag and _should_ be passed to configure (but isn't without this patch). Similarly, every line in the 'enable' file is explicitly enabled. This functionality is definitely required because various gst-plugin components are broken from time to time with different setups and it is often most productive to just be able to disable them and work with what's left rather than get sidetracked fixing up yet another build problem.
Assigning to thomasvs for review.
fixed in CVS, please test and reopen if not to satisfaction.