GNOME Bugzilla – Bug 107869
Watch/Ignore should handle flatfish's moron newsreader's broken References headers
Last modified: 2006-06-18 05:09:17 UTC
Using scoring as a substitute for watching and ignoring threads doesn't really work: 1. Watch/Ignore Thread are missing in the right-click menu. 2. It's too cumbersome having to go throuh the scoring dialogue to watch or ignore a thread. 3. Scoring on reference is not a sufficient substitute for Watch/Ignore Thread, for several reasons: A. The initial post isn't marked, thus the thread isn't properly coloured when collapsed. B. In very long (deep) threads, some of the articles aren't coloured, because the oldest references are dropped. C. There's no easy way to watch the entire thread from unthreaded view or when using searching or filtering that only shows parts of the thread, e.g. "Show Only Replies to My Articles". 3A could be solved by also scoring on message-ID. Either scoring on reference should also include message-ID, or there should be three options: - Score on reference only. - Score on message-ID only. - Score on reference/message-ID. I'm not sure if scoring on reference only is very useful, but I think scoring on message-ID only could be. Anyway, I'd like the old watch/ignore thread back. For my use, they're more valuable than scoring.
I don't want to re-add the old watch/ignore code back into Pan, because it's really just a duplication of a subset of the scorefile. However, the "user experience" of watch/ignore was better before, and we should try to get back to that before 0.14.0. 1. Watch/Ignore in the right-click menu: this is pretty easy. 2. I agree with this; we can skip the dialog. 3. We can revert to `watch thread' rather than 0.13.90's implicit `watch subthread', which will fix all these items. `watch subthread' can be added later and handled separately.
Implemented 2 and 3 in CVS... http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/filters&command=DIFF_FRAMESET&file=score.h&rev1=1.1&rev2=1.2&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/filters&command=DIFF_FRAMESET&file=score.c&rev1=1.3&rev2=1.4&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/filters&command=DIFF_FRAMESET&file=filter-phrase.h&rev1=1.11&rev2=1.12&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/filters&command=DIFF_FRAMESET&file=filter-phrase.c&rev1=1.19&rev2=1.20&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/base&command=DIFF_FRAMESET&file=article.h&rev1=1.37&rev2=1.38&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/base&command=DIFF_FRAMESET&file=article.c&rev1=1.75&rev2=1.76&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=score-add-ui.c&rev1=1.1&rev2=1.2&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=gui.c&rev1=1.564&rev2=1.565&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=articlelist.c&rev1=1.610&rev2=1.611&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=article-actions.h&rev1=1.14&rev2=1.15&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=article-actions.c&rev1=1.47&rev2=1.48&root=/cvs/gnome
1. Watch/Ignore is still missing in the right-click menu. 3B. In very deep threads, the outermost articles still aren't coloured. Even if the current article is one of the outermost ones when "Watch Thread" is invoked, it isn't coloured. BTW: 4. It should be possible to change the default lifespan for watched/ignored threads in Preferences. "Never expire" should be available. (Actually, it would be nice if it expired when no articles from the thread are available anymore.) 5. Watch/ignore should always set the score to +/-9999, as the comment in the score dialogue says. Now Pan sets the score to the value for "very high/low score" from Preferences. I changed the threshold to 9000 in order to prevent a rule that subtracts a small score from "unwatching" the thread, but that didn't work. 6. An *additional* "Watch/Ignore Subthread" would still be nice.
1. True, I'll look into that. 3b. Got a group + thread I can test with? 4. No, for at least four reasons. In order of importance: (1) "never expire" is a bad idea in general, since the killfile will continue to build and build, slowing Pan down by doing checks against threads that have been dead for months or years. (2) Users who *really* want to do this can do so by editing the scorefile by hand, even if the GUI doesn't allow the practice. (3) I just finished taking the dialog -- which has this functionality -- out of watch/ignore, and now you're asking me to duplicate those gui pieces in a preferences dialog. ;) (4) This bug ticket is about making the new code emulate the old watch/ignore implementation. The old watch/ignore automatically expired after a month. 5. I'm thinking that user-configurable thresholds should be dropped, as they don't appear to be often used in slrn and don't appear to be changable at all in XNews. So it's probably in the interest of compatability to remove this feature. File a separate bug report for this. 6. File a separate bug report for this.
3B, example, top of thread: Newsgroups: comp.os.linux.advocacy Subject: Folks I guess you were right Message-ID: <pyeca.1280$ug5.163569@twister.kc.rr.com> Date: Fri, 14 Mar 2003 00:23:43 -0600 When I reach the 11th level (the second posting from "flatfish"), the message-ID above is not included in the references. This and the subsequent articles are not coloured/scored. In 0.13.4, all articles in this thread are coloured. Another example can be found in the same group on March 11, "Google Search Umm [...]", from Jim Lascola. As I'm currently unable to connect (DNS servers down?), and none of the articles in this thread are cached, I'm unable to see the message-ID. Anyway, here it looks like references are truncated in at least three places, at different levels.
1. fixed in CVS: http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=articlelist.c&rev1=1.612&rev2=1.613&root=/cvs/gnome 3b. He's got a newsreader that's trimming the FIRST entry in the References header, d'oh! And this newsgroup is up in arms about Pan's handling of message/rfc822?! Since this is the only issue left open in this ticket's list about watch/ignore, I'm changing the ticket's subject. You should still file new reports for items (5) and (6), as they're different issues.
Unfortunately Flatfish's "moron newsreader" is Agent, so this is probably a bigger problem. Moving to critical; the broken References header needs to be fixed before 0.13.92. Hiya flatty. ;)
Fixed in CVS: http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/filters&command=DIFF_FRAMESET&file=filter-phrase.c&rev1=1.20&rev2=1.21&root=/cvs/gnome