After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 107700 - Creating a button on panel with link to filename in non-latin is impossible
Creating a button on panel with link to filename in non-latin is impossible
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
2.2.x
Other other
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-03-06 06:36 UTC by Dmitry G. Mastrukov
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
convert .desktop file contents to filenames. (1.83 KB, patch)
2003-06-02 19:55 UTC, Hidetoshi Tajima 		none Details | Review

Description Dmitry G. Mastrukov 2003-03-06 06:36:45 UTC 
Creating of button on panel with link to non-latin filename causes 'Error
while loading or saving configuration informarion' with 'Invalid UTF-8
sequence' detail message. Locale is non-UTF8, G_BROKEN_FILENAMES=1 is set.
Comment 1 Mark McLoughlin 2003-03-06 18:33:47 UTC 
Toshi: this sounds like one of the many similar issues you fixed
Comment 2 Hidetoshi Tajima 2003-03-06 18:49:06 UTC 
what's the exact steps to reproduce this? I cannot find
how I do "creating of buttons on panel with a link to a filename".
Comment 3 Dmitry G. Mastrukov 2003-03-07 05:03:00 UTC 
Add to panel->launch button
In dialog you shoud choose type "link". I think type can be
"Application" or other to reproduce that error too, but I have no app
with non-latin filename. Next press "Browse", choose non-latin
filename and press OK - error message will appear.
Sorry for possible non-correct names of panel menu entries - I
retranslate them from Russian back to English :)
Comment 4 Hidetoshi Tajima 2003-06-02 19:52:43 UTC 
This looks like a gnome-desktop bug. File contents
of launcher .desktop files are always encoded in 
UTF-8, hence when we g_spwan_*() with the string
it has to be converted to filesystem's filename 
using g_filename_from_utf8().

Attaching a patch. Since the patch is against the
primitive gnome-desktop function, other similar 
bugs, if any, would be fixed by this patch, so
this should be carefully reviewed before commit
Mark, will you please?
Comment 5 Hidetoshi Tajima 2003-06-02 19:55:13 UTC 
Created attachment 17069 [details] [review]
convert .desktop file contents to filenames.
Comment 6 Mark McLoughlin 2003-06-03 12:23:47 UTC 
Toshi: the patch looks (and sounds) good to me. I know you'd like me
to review it carefully, but on this issue I trust your judgement
better than mine.

If you're comfortable with it, please go ahead and commit ...

Thanks.
Comment 7 Hidetoshi Tajima 2003-06-03 17:03:51 UTC 
Thanks, commit to both gnome-2-2 and HEAD.