After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 107682 - GnomeFontPicker style button
GnomeFontPicker style button
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.2.x
Other other
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2003-03-06 00:58 UTC by Matthias Clasen
Modified: 2011-02-04 16:12 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
gtkfontpickerbutton.h (3.96 KB, text/plain)
2003-03-06 00:59 UTC, Matthias Clasen
  Details
gtkfontpickerbutton.c (25.98 KB, text/plain)
2003-03-06 01:00 UTC, Matthias Clasen
  Details
patch (2.55 KB, patch)
2003-03-06 23:04 UTC, Matthias Clasen
none Details | Review
gtkfontpickerbutton.c (30.16 KB, text/plain)
2003-03-08 00:42 UTC, Matthias Clasen
  Details
gtkfontpickerbutton.h (4.18 KB, text/plain)
2003-03-08 00:43 UTC, Matthias Clasen
  Details
an example (2.43 KB, image/png)
2003-03-08 00:44 UTC, Matthias Clasen
  Details
gtkfontselbutton.h (4.73 KB, text/plain)
2003-03-17 20:32 UTC, Matthias Clasen
  Details
gtkfontselbutton.c (31.13 KB, text/plain)
2003-03-17 20:32 UTC, Matthias Clasen
  Details
gtkfontbutton.h (3.98 KB, text/plain)
2003-03-19 00:51 UTC, Matthias Clasen
  Details
gtkfontbutton.c (28.09 KB, text/plain)
2003-03-19 00:52 UTC, Matthias Clasen
  Details
gtkfontbutton.h (4.06 KB, text/plain)
2003-06-29 13:55 UTC, Matthias Clasen
  Details
gtkfontbutton.c (29.07 KB, text/plain)
2003-06-29 13:56 UTC, Matthias Clasen
  Details
gtkfontbutton.h - incorporating feedback from Soeren & Owen (4.34 KB, text/plain)
2003-06-30 18:27 UTC, Matthias Clasen
  Details
gtkfontbutton.c - incorporating feedback from Soeren & Owen (29.01 KB, text/plain)
2003-06-30 18:29 UTC, Matthias Clasen
  Details

Description Matthias Clasen 2003-03-06 00:58:36 UTC
I took the font picker found in libgnomeui, adapted it to the gtk
coding style and simplified it a bit (no modes, hardwire font_info mode).
Comment 1 Matthias Clasen 2003-03-06 00:59:25 UTC
Created attachment 14805 [details]
gtkfontpickerbutton.h
Comment 2 Matthias Clasen 2003-03-06 01:00:11 UTC
Created attachment 14806 [details]
gtkfontpickerbutton.c
Comment 3 Matthias Clasen 2003-03-06 23:03:28 UTC
Here is a patch which adds the font picker to gtk/Makefile.am and
modifies testgtk to demonstrate a font picker.
Comment 4 Matthias Clasen 2003-03-06 23:04:10 UTC
Created attachment 14825 [details] [review]
patch
Comment 5 Matthias Clasen 2003-03-08 00:41:33 UTC
Here is a version of the font picker which optionally displays the
style of the selected font as well.
Comment 6 Matthias Clasen 2003-03-08 00:42:46 UTC
Created attachment 14846 [details]
gtkfontpickerbutton.c
Comment 7 Matthias Clasen 2003-03-08 00:43:35 UTC
Created attachment 14847 [details]
gtkfontpickerbutton.h
Comment 8 Matthias Clasen 2003-03-08 00:44:28 UTC
Created attachment 14848 [details]
an example
Comment 9 Matthias Clasen 2003-03-17 20:17:13 UTC
I decided to rename it to GtkFontSelectionButton.
Comment 10 Matthias Clasen 2003-03-17 20:32:02 UTC
Created attachment 15082 [details]
gtkfontselbutton.h
Comment 11 Matthias Clasen 2003-03-17 20:32:53 UTC
Created attachment 15083 [details]
gtkfontselbutton.c
Comment 12 Matthias Clasen 2003-03-19 00:50:47 UTC
Here is a new version, which is now called GtkFontButton for brevity.
Main changes:

* indentation fixes
* replace GTK_TYPE boilerplate by G_TYPE boilerplate
* label_font_size is gone in favor of use_size. You now have the choice 
to use either the regular font size from the style or the selected
font size.
* preview_text is gone
* broken attempts of instant update removed
* separator between font name and style removed
Comment 13 Matthias Clasen 2003-03-19 00:51:32 UTC
Created attachment 15106 [details]
gtkfontbutton.h
Comment 14 Matthias Clasen 2003-03-19 00:52:21 UTC
Created attachment 15107 [details]
gtkfontbutton.c
Comment 15 Matthias Clasen 2003-06-29 13:55:38 UTC
Created attachment 17890 [details]
gtkfontbutton.h
Comment 16 Matthias Clasen 2003-06-29 13:56:12 UTC
Created attachment 17891 [details]
gtkfontbutton.c
Comment 17 Matthias Clasen 2003-06-29 13:57:37 UTC
The new version has the following changes:
- reduce some excessively long function names
- move to instance private data
- improved documentation
- fixed a few bugs noticed while doing the above
Comment 18 Matthias Clasen 2003-06-30 18:27:49 UTC
Created attachment 17932 [details]
gtkfontbutton.h - incorporating feedback from Soeren & Owen
Comment 19 Matthias Clasen 2003-06-30 18:29:35 UTC
Created attachment 17933 [details]
gtkfontbutton.c - incorporating feedback from Soeren & Owen
Comment 20 Matthias Clasen 2003-07-01 20:05:35 UTC
Committed, including docs and demos.