GNOME Bugzilla – Bug 107611
Have a default panel "name" in the properties dialog
Last modified: 2015-03-24 13:01:17 UTC
When a panel has no user specified name we should put whatever we use as the window title in the name entry. PanelToplevel currently tries to be funky and come up with names based on the current panel position, but I'm not sure whether or not this is a good idea.
If the automatically inferred names work well most of the time, I would vote for not including a preference for this.
I feel it's better to remove the pref unless there's a real usage of the panel name for the user (but I can't find one).
gnopernicus could prolly read out the name of the panel while switching between panels.
If we have reasonable automatic names (shouldn't be terribly hard), I don't think we should clutter the interface with weird things like naming (???) panels.
Agreed, I can't imagine people will have so many similarly-placed panels of the same type that default names based on those two properties (for example) wouldn't be good enough.
Created attachment 28362 [details] [review] When u apply this patch, It will give the default panel name as "GNOME Panel" if no name is assigned to the panel. This will give the default name "GNOME Panel " to the panel properties. You can change the name of the panel as usual.
Weren't we kind of in agreement that the name field should just disappear? And if we weren't, this patch doesn't seem to do the right thing, to me... as Mark said right at the top, the default name in the dialog should be the one you see when you use Ctrl-Alt-Tab to move focus to it, regardless of how sensible or otherwise we think that name currently is :)
Calum: So the GConf name thingie should vanish as well, right? If we really agree on it, I can write some patches. I don't want to waste effort, though. regs, Chris
The autogenerated names seem to generate enough perfectly reasonable names so I don't see a need have a preference for this. After seeing the JDS accessibility demo at GUADEC I think the 'GNOME Panel' name is a bad idea. I chuckled out loud when I heard gnopernicus say 'Sun Microsystems Java Desktop Top Panel' one too many times. The branding is just over the top, while the location descriptive names sound helpful. Having a GConf value gives configurability for this and I don't know about taking that away from admins making their desktop conform to some kind of spec. However I don't have a strong opinion on this, I'd defer to the maintainers choice.
Created attachment 30412 [details] [review] Proposed patch. This patch removes the name label/entry from the panel property dialog.
Comment on attachment 30412 [details] [review] Proposed patch. Byran's rationale sounds fairly reasonable - please commit Manny