Bug 107401 – Wrong sense of test for panel_background_color

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 107401 - Wrong sense of test for panel_background_color


Summary:	Wrong sense of test for panel_background_color


Status:	RESOLVED FIXED

Product:	gnome-panel
Classification:	Other
Component:	panel
Version:	unspecified
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Panel Maintainers
QA Contact:	Panel Maintainers

URL:
Whiteboard:

Duplicates:	104808 110122 110781 (view as bug list)
Depends on:
Blocks:

Reported:	2003-03-02 17:42 UTC by Greg Hudson
Modified:	2004-12-22 21:47 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Greg Hudson 2003-03-02 17:42:13 UTC

Lines 2270-2272 of panel.c currently read:

	tmp_str = panel_get_string (profile, panel_id, "panel_background_color",
NULL);
	if (!tmp_str || !tmp_str [0]) {
		gdk_color_parse (tmp_str, &gdkcolor);

This test is backwards.  If panel_background_color is present, it will be
ignored, and if it is absent, gdk_color_parse will be called with an
invalid argument, yielding a critical error message from pango.

Comment 1 Mark McLoughlin 2003-03-02 20:07:12 UTC

*** Bug 104808 has been marked as a duplicate of this bug. ***

Comment 2 Mark McLoughlin 2003-03-02 20:10:35 UTC

Thanks much for pinning this down Greg.

2003-03-03  Mark McLoughlin  <mark@skynet.ie>
                                                                     
                                       
        * panel.c: (panel_load_panel_from_gconf): load the background
        color when there is one set. Doh. Patch from Greg Hudson,
        ghudson@mit.edu - #107401.

Comment 3 Mark McLoughlin 2003-04-11 02:11:16 UTC

*** Bug 110122 has been marked as a duplicate of this bug. ***

Comment 4 Ian Scott 2003-04-11 02:35:13 UTC

I'm not a programmer - how exactly do I correct this? :)  

Should I add that line:
* panel.c: (panel_load_panel_from_gconf): load the background
        color when there is one set. 

somewhere in panel.c?

Thanks!

Comment 5 Mark McLoughlin 2003-04-11 02:49:34 UTC

Upgrade preferably ...

Or change:

if (!tmp_str || !tmp_str [0]) {

to

if (tmp_str && tmp_str [0]) {

Comment 6 Mark McLoughlin 2003-04-14 21:13:17 UTC

*** Bug 110781 has been marked as a duplicate of this bug. ***