After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 107186 - We need a newer ffmpeg snapshot in HEAD
We need a newer ffmpeg snapshot in HEAD
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.6.0
Other Linux
: Normal normal
: 0.6.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 112597 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-02-27 12:46 UTC by Marinus Schraal
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
disable ffmpeg mpeg typefind (923 bytes, patch)
2003-02-27 12:47 UTC, Marinus Schraal 		none Details | Review

Description Marinus Schraal 2003-02-27 12:46:17 UTC 
For some mp3s ffmpegs typefind returns video/mpeg, which makes these files
unplayable in apps. Probably could be solved by changing order of
typefinding (going trough mp3 typefinder before going trough ffmpeg), but i
don't know if this is possible. This looks like a typedetection bug in ffmpeg.

I made this small patch to the ffmpeg typefinder to not check for mpegs. I
don't think this has much impact, since there are other video/mpeg finders
and now my mp3s do show up correctly.
Comment 1 Marinus Schraal 2003-02-27 12:47:31 UTC 
Created attachment 14653 [details] [review]
disable ffmpeg mpeg typefind
Comment 2 Christian Fredrik Kalager Schaller 2003-03-31 08:12:29 UTC 
This patch should be merged before 0.6.1
Comment 3 Benjamin Otte (Company) 2003-04-01 16:26:28 UTC 
2 things:
1) It's fixed in current ffmpeg cvs, so please don't apply to HEAD.
(link to fix is http://cvs.sourceforge.net/cgi-
bin/viewcvs.cgi/ffmpeg/ffmpeg/libavformat/mpeg.c.diff?r1=1.21&r2=1.22 
- split by bugzilla)
2) if you comment out some part of the code, please add a comment to 
the source saying why you did so (like "disabling because ffmpeg 
v0.x.y detects lots of mp3 files as video/mpeg") or someone else 
might reenable it some day because he wonders why that line is 
commented out.

Someone please apply to 0.6 and close this bug.
Comment 4 Ronald Bultje 2003-04-01 18:30:30 UTC 
If it's fixed, we shoul try to get a newer snapshot of ffmpeg's CVS in
HEAD. 0.6 can keep on using the current version with this patch.
Comment 5 Ronald Bultje 2003-04-07 17:08:57 UTC 
Fixed in 0.6.1 CVS. Topic changed to reflect changes needed in HEAD CVS.
Comment 6 Ronald Bultje 2003-05-29 21:01:20 UTC 
HEAD has new ffmpeg snapshot now.
Comment 7 Ronald Bultje 2003-05-29 21:01:40 UTC 
*** Bug 112597 has been marked as a duplicate of this bug. ***