GNOME Bugzilla – Bug 106875
mpegdemux doesn't support linear PCM streams
Last modified: 2004-12-22 21:47:04 UTC
The mpegdemux element is not able to extract linear PCM streams from DVD VOB files. Linear PCM streams are PES packets in the "private stream 1" range (id 0xBD, sub id. 0xA0 to 0xA7). The complete packet format is described in http://members.freemail.absa.co.za/ginggs/dvd/mpeg2_lpcm.txt.
Created attachment 14554 [details] [review] A tentative patch to fix this problem
Since you are calling it tentative I guess Wim should comment on it before I commit ;) So Wim, what do you say?
I would suggest to change the mime-type to audio/x-lpcm as audio/pcm is not registered. Otherwise, the patch looks good.
Patch merged into CVS head and Martin added to 0.7 release notes credits. Thanks for the patch Martin!
Created attachment 16067 [details] [review] A complete patch to support linear PCM in mpegdemux
I'm reopening this bug since I now have a new bunch of changes. The changes in the original patch are not really enough, and the new patch I just attached, provides the remaining code necessary for full linear PCM support. Now, PCM sound will be delivered as raw audio, with correctly set capabilities. During the last days, I've been using this together with audioconvert to play DVDs, it works pretty well.
Assigning to Ronald for general and 0.6x review.
I've committed the patch to HEAD. Thanks for the work! Re: 0.6.2. That's interesting, but this patch will not work. 0.6.x doesn't have an audioconvert plugin, so we'd need to do in-plugin byte swapping. There's probably some more work needed too, plus more testing. We won't finish that before 0.6.2, sorry. I am keeping it open for 0.6.3. If we have too much free time we can try getting this in 0.6.2, but I won't have that time. If anyone else feels like doing it, please go ahead.
This is not going to be backported, as 0.8 is nigh.