GNOME Bugzilla – Bug 106726
Save all images
Last modified: 2008-05-27 19:10:12 UTC
I have noticed that many gnome apps have a "close all" option in the file menu. Some also have a "save all" option. I think it would be nice to have such options to close/save all the image windows at once as it is common to use many images at the same time. It's only cosmetic, I agree, but may be nice and not so hard to code. I think it should be in the contextual file menu, and maybe also in the toolbox file menu. In case interaction is needed, the pop up windows ("do you want to save it first" or "save as ...") could come one after another, or perhaps all at a time. Should have I made two bug reports? (1 for close all, 1 for save all)
We thought about changing the "Really Quit?" dialog that reminds you of unsaved images. It could contain a list of unsaved images (with previews) and would allow the user to select which ones to save (and a button to select all). This solution wouldn't clutter the menu but it wouldn't allow to save all images w/o quitting The GIMP.
Changes at the request of Dave Neary on the developer mailing list. I am changing many of the bugzilla reports that have not specified a target milestone to Future milestone. Hope that is acceptable.
This would be a very easy thing to implement, and it would be nice to have. I'll set it to 2.0, but it's ok if it doesn't actually get implemented.
Since this is a feature request, it would be nice to get it considered before the feature freeze, so I'm setting a 1.3.x target on it. Dave.
I figure you could do this adding a Close All Ctrl+Shift+W menu item and prompt the user to save each dirty document as necessary. Just to be absolutely clear, Quit closes all Windows including the toolbox and exits, whereas Close All just closes all the documents leaving the Toolbox (and Dialogs) open.
Bumping a bunch of enhancement requests which will not be done by the feature freeze to Future. Dave.
IMO we should attempt to fix this before 2.0 but it's not a blocker.
I agree with Sven. I just got done with a group of images and sometimes I do wish there was an easy way to just close all files. Maybe if some are unsaved with changes, a popup window could come up listing the files that haven't been saved yet with a check box next to each one so that the user could choose which ones to save or not. And the buttons could be "Close All", "Save All", "Save & Exit" (last one if the user checked some files but not others), and "Cancel" (to just go back and not close anything or save anything).
*** Bug 131451 has been marked as a duplicate of this bug. ***
*** Bug 142624 has been marked as a duplicate of this bug. ***
Bug #142624 has a nice description of how the Close dialog could look like. Setting on the 2.2 milestone.
The quit dialog in CVS now has a list of dirty images. It shouldn't be too hard to add check buttons that allow to select the files to save. gedit has this implemented quite nicely, it's worth looking at.
Somewhat related: 2004-09-13 Sven Neumann <sven@gimp.org> * app/display/gimpdisplayshell-close.c: as suggested by the HIG, ask the user to save the image when the last display is being closed. Addresses some issues raised in bug #106726.
IMHO the current quit dialog is good enough for the 2.2 release. We can improve it further during the next development cycle.
The "Close All" feature is handled in bug #163532. Having two different things in a single bug report is a bad idea so it's a good thing that there's now two different enhancement requests for it.
Ugrading target from Future to 2.6.
Created attachment 101965 [details] [review] Adds save all function. It's still a little bit hackish, any suggestions to refine would be great. Great thanks to bil1 and Enseric for their help on IRC.
Do we really want a "Save All" menu item? I think the main use case for this is when you quit GIMP. And then this could be in the dialog that is telling you about unsaved images. It wouldn't have to clutter the menus then.
I think the window added in 2004 when closing gimp with unsaved files (cf. comment 12) and the "Close all" of comment 15 is enough for me. When I opened the bug, those did not exist, so it the menu seemed like the place to have this "save all". But I agree that it is not needed any more to have a menu item (IMHO).
It would still be nice to have an easier way to save unsaved images from the Close dialog. Perhaps we need to open a new bug report for that.
I'm not happy with the way this bug report has been handled: it was marked as gnome-love. A new developer should be able to assume that a bug marked as gnome-love is a genuine bug, and that if a proper solution is provided, it will be used. To decide, after a solution is proposed, that the issue really isn't a bug after all, is a very discouraging way to treat a potential new developer. We should at least make some effort to ensure that gnome-love bugs are valid bugs. There are only 17 of them, so it shouldn't be incredibly difficult. Looking them over, I think probably bug #132204, #338380, and #119646 should no longer be marked, because they are mostly fixed. The others seem okay to me, except of course this one. It would also perhaps be worth picking a few more straightforward and clearly desirable enhancements to mark as gnome-love.
You are right. I am also very unhappy on what happened here. Feel free to do what you suggested in comment #21, but let's keep this bug focused on the subject and check what we can use from the code that Patrick wrote.
I had a look at the patch and while it is nicely done, I am afraid that we cannot accept it since it uses a blocking call to gtk_dialog_run(). This is not acceptable in the GIMP core. We could change this to gimp_dialog_run() but it looks to me that the code wouldn't deal gracefully with all the things that could happen when the dialog is not modal. Let's try to figure out what we actually want.
I suggest that we close this bug as WONTFIX.
In short, Patrick, we apologize for mishandling this bug report -- it should not have been marked as "gnome-love". I agree with WONTFIX and will resolve accordingly. The question can perhaps be reopened if future usability studies show that large numbers of users feel a need for a "Save All" command.
*** Bug 535073 has been marked as a duplicate of this bug. ***