GNOME Bugzilla – Bug 106355
Patch for a leak in the panel
Last modified: 2004-12-22 21:47:04 UTC
This patch fixes some leaks reported by memprof. Please review to see if it's sane.
Created attachment 14396 [details] [review] patch to fix a leak
Kjartaan: well, it only makes sense on the gnome-2-2 branch. Make sure to wrap it with #ifndef FIXME and a big comment to say that it should be re-enabled when the applet menu re-checking code is re-enabled. But, yeah - go ahead and commit to gnome-2-2. Thanks.
Are you sure? I saw some crashes when opening gnome-session-properties after doing this so maybe the fix is slightly off?
Or maybe it's triggering some other problem?
I *think* it only happened when running the panel in memprof
Hmm, the fix looks sane to me. If its causing weird things to happen on your system, though, don't commit until you've figure out that ...
I filed the weirdness as a separate bug with a comment.
Could you look at http://bugzilla.gnome.org/show_bug.cgi?id=106356 to see if you can figure out if the patch here causes that?
I bet your crash is the gnome-desktop mem corruption bug when using startup notification that olivier fourdan reported. there's a patch on olivier's bug.
Havoc is right. Applying both fixed the crash mentioned in #106356
Created attachment 14425 [details] [review] updated patch
Does this patch look ok to you Mark?
yep
This was committed right ?
Yes it was.