After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 106355 - Patch for a leak in the panel
Patch for a leak in the panel
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
2.2.x
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on: 106356
Blocks:
 
 
Reported: 2003-02-17 23:02 UTC by Kjartan Maraas
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.1/2.2


Attachments
patch to fix a leak (451 bytes, patch)
2003-02-17 23:03 UTC, Kjartan Maraas
none Details | Review
updated patch (659 bytes, patch)
2003-02-18 22:23 UTC, Kjartan Maraas
none Details | Review

Description Kjartan Maraas 2003-02-17 23:02:29 UTC
This patch fixes some leaks reported by memprof. Please review to see if
it's sane.
Comment 1 Kjartan Maraas 2003-02-17 23:03:03 UTC
Created attachment 14396 [details] [review]
patch to fix a leak
Comment 2 Mark McLoughlin 2003-02-17 23:24:35 UTC
Kjartaan: well, it only makes sense on the gnome-2-2 branch. Make sure
to wrap it with #ifndef FIXME and a big comment to say that it should
be re-enabled when the applet menu re-checking code is re-enabled.
But, yeah - go ahead and commit to gnome-2-2. Thanks.
Comment 3 Kjartan Maraas 2003-02-17 23:27:11 UTC
Are you sure? I saw some crashes when opening gnome-session-properties
after doing this so maybe the fix  is slightly off?
Comment 4 Kjartan Maraas 2003-02-17 23:28:24 UTC
Or maybe it's triggering some other problem?
Comment 5 Kjartan Maraas 2003-02-17 23:34:39 UTC
I *think* it only happened when running the panel in memprof
Comment 6 Mark McLoughlin 2003-02-17 23:36:21 UTC
Hmm, the fix looks sane to me. If its causing weird things to happen
on your system, though, don't commit until you've figure out that ...
Comment 7 Kjartan Maraas 2003-02-17 23:44:40 UTC
I filed the weirdness as a separate bug with a comment.
Comment 8 Kjartan Maraas 2003-02-17 23:46:29 UTC
Could you look at http://bugzilla.gnome.org/show_bug.cgi?id=106356 to
see if you can figure out if the patch here causes that?
Comment 9 Havoc Pennington 2003-02-18 19:52:55 UTC
I bet your crash is the gnome-desktop mem corruption bug when using 
startup notification that olivier fourdan reported. there's a patch 
on olivier's bug.
Comment 10 Kjartan Maraas 2003-02-18 22:22:36 UTC
Havoc is right. Applying both fixed the crash mentioned in #106356
Comment 11 Kjartan Maraas 2003-02-18 22:23:25 UTC
Created attachment 14425 [details] [review]
updated patch
Comment 12 Kjartan Maraas 2003-02-18 22:23:44 UTC
Does this patch look ok to you Mark?
Comment 13 Mark McLoughlin 2003-02-18 23:19:11 UTC
yep
Comment 14 Mark McLoughlin 2003-03-10 02:09:37 UTC
This was committed right ?
Comment 15 Kjartan Maraas 2003-03-17 22:04:04 UTC
Yes it was.