GNOME Bugzilla – Bug 105521
single click: list view should have mouse-over
Last modified: 2005-07-14 16:04:57 UTC
Items in the list view in single click mode should not be underlined (bug 83962) bug should have some sort of mouse over higlighting like in the icon view.
Please, please, someone fix this. All the underlining causes a burning in my eyes. Ow. Burning. Help. So ugly.
Created attachment 46694 [details] [review] Proposed Patch Maybe you could try out whether that patch satisfies you? In single-click mode, it will turn the cursor into a hand if when it is over a row and only hover the row under the cursor.
Created attachment 46696 [details] [review] Proposed Patch #2 Should improve hover experience. Don't request redraw of whole widget, just emit "row_changed" on rows which experienced an underline toggle.
Reminder: If the list view's behaivor in single click mode is changed in nautilus is changed then it needs to also be changed in file-roller and gnome-search-tool, too.
+leave_notify_callback (GtkWidget *widget, ... + gtk_widget_queue_draw (widget); Why call this instead of emitting row_changed. fm_list_view_click_policy_changed (FMDirectoryView *directory_view): this doesn't emit row_changed if view->details->hover_path is set.
Created attachment 49082 [details] [review] Proposed patch #3 Good catch.
Thanks for pointing this issue out. Dennis, Paolo, is this OK with you? Do you still have enough time to adapt the search tool and file roller?
file-roller is fixed now.
Paolo: Great! Don't forget gThumb :).
I have created a patch on my local version of gnome-search-tool. Please let me know when the nautilus changes are applied and I will apply my patch to gnome-search-tool. Thanks.
I added some protection against the hover_path going stale (due to deletes or something) and made sure to emit row_changed in policy_changed. The cursor unsetting didn't work, as it was unsetting the curson on a different window. Also i added some protection against non-realized widgets in policy_changed, since it was giving critical errors. I checked in a patch which fixes this. Dennis, you can commit your patch now.
I applied the patch to gnome-search-tool, so its single click to activate behaivor should match nautilus.