After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 105521 - single click: list view should have mouse-over
single click: list view should have mouse-over
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: List View
2.11.x
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-02-07 19:32 UTC by Mark Finlay
Modified: 2005-07-14 16:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
Proposed Patch (5.94 KB, patch)
2005-05-20 22:14 UTC, Christian Neumair
none Details | Review
Proposed Patch #2 (6.44 KB, patch)
2005-05-20 22:28 UTC, Christian Neumair
none Details | Review
Proposed patch #3 (6.65 KB, patch)
2005-07-13 10:17 UTC, Christian Neumair
none Details | Review

Description Mark Finlay 2003-02-07 19:32:55 UTC
Items in the list view in single click mode should not be underlined
(bug 83962) bug should have some sort of mouse over higlighting like
in the icon view.
Comment 1 Jay Kreps 2005-05-20 18:45:50 UTC
Please, please, someone fix this.  All the underlining causes a burning in my
eyes.  Ow. Burning.  Help.  So ugly.
Comment 2 Christian Neumair 2005-05-20 22:14:11 UTC
Created attachment 46694 [details] [review]
Proposed Patch

Maybe you could try out whether that patch satisfies you? In single-click mode,
it will turn the cursor into a hand if when it is over a row and only hover the
row under the cursor.
Comment 3 Christian Neumair 2005-05-20 22:28:35 UTC
Created attachment 46696 [details] [review]
Proposed Patch #2

Should improve hover experience. Don't request redraw of whole widget, just
emit "row_changed" on rows which experienced an underline toggle.
Comment 4 Dennis Cranston 2005-07-11 20:45:43 UTC
Reminder:  If the list view's behaivor in single click mode is changed in
nautilus is changed then it needs to also be changed in file-roller and
gnome-search-tool, too.
Comment 5 Alexander Larsson 2005-07-13 10:09:07 UTC
+leave_notify_callback (GtkWidget *widget,
...
+		gtk_widget_queue_draw (widget);

Why call this instead of emitting row_changed.

fm_list_view_click_policy_changed (FMDirectoryView *directory_view):
this doesn't emit row_changed if view->details->hover_path is set.

Comment 6 Christian Neumair 2005-07-13 10:17:38 UTC
Created attachment 49082 [details] [review]
Proposed patch #3

Good catch.
Comment 7 Christian Neumair 2005-07-13 10:23:29 UTC
Thanks for pointing this issue out. Dennis, Paolo, is this OK with you? Do you
still have enough time to adapt the search tool and file roller?
Comment 8 Paolo Bacchilega 2005-07-13 14:52:00 UTC
file-roller is fixed now.
Comment 9 Christian Neumair 2005-07-13 14:54:04 UTC
Paolo: Great! Don't forget gThumb :).
Comment 10 Dennis Cranston 2005-07-14 02:12:10 UTC
I have created a patch on my local version of gnome-search-tool.  Please let me
know when the nautilus changes are applied and I will apply my patch to
gnome-search-tool.  Thanks.
Comment 11 Alexander Larsson 2005-07-14 08:23:11 UTC
I added some protection against the hover_path going stale (due to deletes or
something) and made sure to emit row_changed in policy_changed. 

The cursor unsetting didn't work, as it was unsetting the curson on a different
window. Also i added some protection against non-realized widgets in
policy_changed, since it was giving critical errors.

I checked in a patch which fixes this.

Dennis, you can commit your patch now.
Comment 12 Dennis Cranston 2005-07-14 16:04:57 UTC
I applied the patch to gnome-search-tool, so its single click to activate
behaivor should match nautilus.