After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 105497 - const GdkColor
const GdkColor
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other All
: High minor
: ---
Assigned To: Federico Mena Quintero
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2003-02-07 15:53 UTC by Morten Welinder
Modified: 2011-02-04 16:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch with constification. (37.35 KB, patch)
2004-01-07 00:54 UTC, Federico Mena Quintero 		none Details | Review

Description Morten Welinder 2003-02-07 15:53:52 UTC 
The colour parameters of gdk_gc_set_rgb_fg_color and gdk_gc_set_rgb_bg_color
need to be const.
Comment 1 Owen Taylor 2003-04-18 21:31:21 UTC 
Wouldn't hurt, but there are lots of other examples in
gdkgc.h gtkcolorsel.h gtkwidget.h that should get the same
treatment.
Comment 2 Federico Mena Quintero 2004-01-07 00:53:34 UTC 
The attached patch fixes this for all un-consted cases of GdkColor
that I could find that need it.
Comment 3 Federico Mena Quintero 2004-01-07 00:54:12 UTC 
Created attachment 23051 [details] [review]
Patch with constification.
Comment 4 Federico Mena Quintero 2004-01-20 19:39:24 UTC 
Moving this to the "2.4 API freeze" milestone.  It doesn't really
change the API, but the function prototypes do change.
Comment 5 Soren Sandmann Pedersen 2004-01-25 21:47:06 UTC 
I think you should go ahead and commit. 

There are a few GdkColors in gdk/linux-fb/miwideline.[ch] that could
be const'ed, but I really don't think that's worth worrying about.
Comment 6 Federico Mena Quintero 2004-01-26 20:22:01 UTC 
Thanks, committed :)