GNOME Bugzilla – Bug 105148
Leaks in the panel
Last modified: 2004-12-22 21:47:04 UTC
Attaching a couple of leak traces from valgrind. The major one is when autohiding a panel with translparent background. It seems to leak the background pixbuf every time it autohides.
Created attachment 14068 [details] leaks in the panel part two
Created attachment 14069 [details] part one
I tried looking at the one with the pixbuf being leaked, but I couldn't find where to unref it. Hairy code - or mediocre leakhunter. Pick a choice... :-)
It looks to me like panel_background_composite() fills in background->composited_image for BACK_COLOR, but free_composited_resources() only frees that field for BACK_IMAGE. Mark maybe you can check that.
Mark, does this patch look ok?
Created attachment 14427 [details] [review] patch to fix leak of the background
Actually, I think its safe to take out the branch altogether ...
You mean just remove the if (background->type ....) return; test?
Sorry - yeah, that's what I meant.
This has been applied I think. 2003-02-18 Kjartan Maraas <kmaraas@gnome.org> * gnome-run.c: (find_icon_timeout), (selection_changed), (add_icon_idle): Fix leaks. * menu.c: (make_panel_submenu): Don't leak the applet_list. * panel-background.c: (free_composited_resources):Free the background even if it's just a color