After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 105004 - [PATCH] Revamped theme-switcher UI
[PATCH] Revamped theme-switcher UI
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] theme-manager
2.2.x
Other All
: High trivial
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-02-01 18:21 UTC by Christian Neumair
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
I'm a patch. Click me! :) (31.36 KB, patch)
2003-02-01 18:22 UTC, Christian Neumair 		none Details | Review
Result of my work. Doesn't look that much different but definitly better (19.04 KB, image/png)
2003-02-01 18:27 UTC, Christian Neumair 		  Details
New proposed patch against HEAD (73.50 KB, patch)
2003-04-16 16:47 UTC, Christian Neumair 		none Details | Review
Sorry, wrong attachment. Trying again. (61.55 KB, patch)
2003-04-16 16:51 UTC, Christian Neumair 		none Details | Review
PNG image illustrating my changes (73.50 KB, image/png)
2003-04-16 16:53 UTC, Christian Neumair 		  Details
New patch, applies cleanly against HEAD. (69.02 KB, patch)
2003-05-24 23:52 UTC, Christian Neumair 		none Details | Review
New screenshot. (71.16 KB, image/png)
2003-05-25 13:36 UTC, Christian Neumair 		  Details

Description Christian Neumair 2003-02-01 18:21:23 UTC 
I just spent this afternoon hacking on the gnome-theme-manager UI.
Not sure whether we should commit this before GNOME 2.2 final.
Really urgent (the old one looks broken) so instantly CCing the two
maintainers 

regs,
 Chris
Comment 1 Christian Neumair 2003-02-01 18:22:57 UTC 
Created attachment 14024 [details] [review]
I'm a patch. Click me! :)
Comment 2 Christian Neumair 2003-02-01 18:27:08 UTC 
Created attachment 14025 [details]
Result of my work. Doesn't look that much different but definitly better
Comment 3 Andrew Sobala 2003-02-01 18:30:09 UTC 
We're in feature freeze, UI freeze, and 2 days before tarballs are due
for 2.2.0.
Comment 4 Jody Goldberg 2003-02-01 19:14:46 UTC 
Looks like some glade border size tweakage.  We can consider this in the 2.2.1
time frame but definitely not for 2.2.0.  However, it's jonathan's code and
jonathan's call about whether or not to apply it at that point.
Comment 5 Christian Neumair 2003-04-16 16:47:52 UTC 
Created attachment 15771 [details] [review]
New proposed patch against HEAD
Comment 6 Christian Neumair 2003-04-16 16:51:48 UTC 
Created attachment 15772 [details] [review]
Sorry, wrong attachment. Trying again.
Comment 7 Christian Neumair 2003-04-16 16:53:44 UTC 
Created attachment 15773 [details]
PNG image illustrating my changes
Comment 8 Christian Neumair 2003-04-16 16:59:25 UTC 
Changing some bug data.

Note: The patch should be 100% HIG compliant, just try it out!

regs,
 Chris
Comment 9 Kjartan Maraas 2003-04-22 22:58:39 UTC 
Is this good to go?
Comment 10 Christian Neumair 2003-05-24 23:52:51 UTC 
Created attachment 16813 [details] [review]
New patch, applies cleanly against HEAD.
Comment 11 Christian Neumair 2003-05-24 23:56:11 UTC 
I corrected some wrong assumptions about default dialog spacing and
moved the font suggestion part to a separate area below the theme list
treeview. This makes the layout much cleaner as the discriptions no
longer enlarge the buttons on the right side and we save an obsolete
separator.

regs,
 Chris
Comment 12 Christian Neumair 2003-05-25 13:36:21 UTC 
Created attachment 16822 [details]
New screenshot.
Comment 13 Christian Neumair 2003-05-28 16:23:28 UTC 
Commited. Closing.

regs,
 Chris
Comment 14 Christian Neumair 2003-05-28 16:23:56 UTC 
Do'h. Really close bug this time.

regs,
 Chris