GNOME Bugzilla – Bug 104907
configure check for libgnomeui 2.0 instead of 2.1
Last modified: 2004-12-22 21:47:04 UTC
Well, the configure check ok's libgnomeui 2.0, whereas it should have 2.1 or 2.2 due to this : gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -I/usr/include/metacity-1 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/X11R6/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/X11R6/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/linc-1.0 -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/gnome-desktop-2.0 -I../../ -DG_LOG_DOMAIN="\"-properties\"" -DGNOMELOCALEDIR="\"/usr/share/locale\"" -I../../capplets/common -DGLADEDIR=\""/usr/share/control-center-2.0/interfaces"\" -march=athlon-tbird -O2 -pipe -Wall -c theme-thumbnail.c theme-thumbnail.c:14:41: libgnomeui/gnome-icon-theme.h: No such file or directory theme-thumbnail.c: In function `create_image': theme-thumbnail.c:120: `GnomeIconTheme' undeclared (first use in this function) theme-thumbnail.c:120: (Each undeclared identifier is reported only once theme-thumbnail.c:120: for each function it appears in.) theme-thumbnail.c:120: `icon_theme' undeclared (first use in this function) theme-thumbnail.c:200: warning: implicit declaration of function `gnome_icon_theme_new' theme-thumbnail.c:201: warning: implicit declaration of function `gnome_icon_theme_set_allow_svg' theme-thumbnail.c:202: warning: implicit declaration of function `gnome_icon_theme_set_custom_theme' theme-thumbnail.c:205: warning: implicit declaration of function `gnome_icon_theme_lookup_icon' theme-thumbnail.c:205: warning: assignment makes pointer from integer without a cast theme-thumbnail.c:207: warning: assignment makes pointer from integer without a cast make[3]: *** [theme-thumbnail.o] Error 1 ---- found out of mistake, but thought I'd give a heads-up about it :)
setting severity to minor.
2.2.0 should cleanly compile, really :-)
Created attachment 13997 [details] [review] Proposed patch
looks good to me
modify to this instead: +COMMON_MODULES="gtk+-2.0 >= 2.2.0 gconf-2.0 libgnomeui-2.0 >= 2.2.0 libglade-2.0 >= 1.99.12 libbonobo-2.0 libbonoboui-2.0 libglade-2.0 gconf-2.0 gnome-desktop-2.0 >= 2.2.0" gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -I/usr/include/metacity-1 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/X11R6/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/X11R6/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/linc-1.0 -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/gnome-desktop-2.0 -I../../ -DG_LOG_DOMAIN="\"-properties\"" -DGNOMELOCALEDIR="\"/usr/share/locale\"" -I../../capplets/common -DGLADEDIR=\""/usr/share/control-center-2.0/interfaces"\" -march=athlon-tbird -O2 -pipe -Wall -c gnome-theme-manager.c In file included from /usr/include/libgnomeui-2.0/libgnomeui/libgnomeui.h:56, from /usr/include/libgnomeui-2.0/gnome.h:7, from ../../capplets/common/capplet-util.h:27, from gnome-theme-manager.c:18: /usr/include/libgnomeui-2.0/libgnomeui/gnome-icon-theme.h:54: conflicting types for `GnomeIconDataPoint' /usr/include/gnome-desktop-2.0/libgnome/gnome-icon-loader.h:55: previous declaration of `GnomeIconDataPoint' /usr/include/libgnomeui-2.0/libgnomeui/gnome-icon-theme.h:65: conflicting types for `GnomeIconData' /usr/include/gnome-desktop-2.0/libgnome/gnome-icon-loader.h:64: previous declaration of `GnomeIconData' make[3]: *** [gnome-theme-manager.o] Error 1 make[3]: Leaving directory `/mnt/build/portage/control-center-2.2.0/work/control-center-2.2.0/capplets/theme-switcher' old gnome-desktop as well :)
Is this still relevant?
Commited on both branches. Thanks.