After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 104744 - at-spi internal dependencies should include libspi
at-spi internal dependencies should include libspi
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: build
unspecified
Other Linux
: Normal normal
: ---
Assigned To: bill.haneman
bill.haneman
Depends on:
Blocks:
 
 
Reported: 2003-01-29 18:32 UTC by bill.haneman
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4


Attachments
patch to config.in, explicitly adding libspi to the dependencies of some at-spi components. (659 bytes, patch)
2003-01-29 18:35 UTC, bill.haneman
none Details | Review
Alternative patch (1.84 KB, patch)
2003-01-30 14:02 UTC, padraig.obriain
none Details | Review

Description bill.haneman 2003-01-29 18:32:53 UTC
the LIBS in configure.in for ATK_BRIDGE_LIBS and 
REGISTRYD_LIBS should include libspi, and they don't.

Attached is a patch; but we should probably fix the at-spi versioning bug
first, before applying, and rev the version then.
Comment 1 bill.haneman 2003-01-29 18:35:01 UTC
Created attachment 13921 [details] [review]
patch to config.in, explicitly adding libspi to the dependencies of some at-spi components.
Comment 2 padraig.obriain 2003-01-30 11:05:22 UTC
Why should ATK_BRIDGE_LIBS and REGISTRYD_LIBS include libspi?

I have looked at how gtk+/gtk deals with needing to refer to libraries
built in gtk+/gdk and this is not the way they do it.
Comment 3 bill.haneman 2003-01-30 11:16:02 UTC
interesting.  This is what laca and sander and I came up with
yesterday... what does gtk+ do?

yesterday's related bug was significant enough to break a number of
things (cspi not pulling in libspi); but this one is subtly different
since the dependency in this case is in a module (in the case of
atk-bridge) and an executable (in the case of registryd).

Comment 4 padraig.obriain 2003-01-30 14:02:43 UTC
Created attachment 13946 [details] [review]
Alternative patch
Comment 5 padraig.obriain 2003-01-30 14:03:21 UTC
Does the alternative patch fix the problem?
Comment 6 bill.haneman 2003-01-30 17:33:55 UTC
thanks padraig; the patch looks right.  I'll test tomorrow.
Comment 7 padraig.obriain 2003-02-13 08:21:38 UTC
Do we want to apply the alternative patch?
Comment 8 bill.haneman 2003-02-13 11:30:49 UTC
I leave it to you, apply if you like; I haven't had time to test it
myself.  If it works for you, please apply since it appears fine to me.
Comment 9 padraig.obriain 2003-02-13 11:38:34 UTC
Patch committed.