GNOME Bugzilla – Bug 104700
Workspace applet incorrectly shows windows leaking into other workspaces
Last modified: 2004-12-22 21:47:04 UTC
I'm seeing this with the workspace switcher applet from gnome-panel 2.1.5 If you have a window that's partially off the screen on the right side, the workspace switcher correctly truncates its thumbnail, since the window only lives on the current workspace. Same thing for if you leak off the bottom. If you put a window such that it leaks off either the right or the left of your workspace, it incorrectly draws the window as spanning multiple workspaces. In case my explanation doesn't quite make sense, I'll attach a screenshot. In it, I've got two examples: one with the windows leaking off to the left & top edges incorrectly, and one with the windows leaking off to the bottom & right edges correctly.
Created attachment 13903 [details] Screenshot of working sides vs not-working sides
Created attachment 20811 [details] [review] Proposed patch
Patch fixes this. Ok to commit ?
This looks fine but you should add a space between gdk_rectangle_intersect and the (, and name the rect something more descriptive than rect_buf (maybe "unclipped_win_rect" or something).
Fixed in HEAD with above comments.