GNOME Bugzilla – Bug 104692
fixed caps state error
Last modified: 2004-12-22 21:47:04 UTC
After Wim's last changes, I get this in gst-player: (lt-gst-player:10968): GStreamer-WARNING **: trying to set non fixed caps on pad colorspace:src, not allowed nautilus-media apparently still works. Still, I guess it needs fixing before 0.6.0 is released.
Created attachment 13898 [details] [review] don't know if that's it, but it's surely a bug
The above thing is definitely a bug, because that line did never do anything. gst_props_empty_new will always set that flag, so or'ing anything with it will not change it. Hm, will attach a cleaner patch for this thing, it looks so cryptic and it's not an obfuscated C contest.
Created attachment 13899 [details] [review] cleaner version of above patch
This is probably a bug, but it's not the ug I'm looking for. ;). Somewhere, it doesn't set the FIXED flag where the boolean used to be TRUE in the old case. Yours does the other way around. It's still a bug, but not the bug that causes my warnings.
Correction, Benjamin's fix fixes the bug. I've got something else (removed crap in gstpad.c) that might also need to be patched - wim? I'll upload Benjamin's patch to CVS so this bug cna be lowered in priority.
Created attachment 13915 [details] [review] related patch to fix something not-100%-correct (imho) in gstpad.c
committed