After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 104569 - both shout plugins do their (dis)connect on the wrong state change
both shout plugins do their (dis)connect on the wrong state change
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other other
: Normal normal
: 0.4.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-01-27 23:33 UTC by Pedro Corte-Real
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for shout2send (1.02 KB, patch)
2003-01-27 23:35 UTC, Pedro Corte-Real 		none Details | Review
Patch for icecastsend (1.26 KB, patch)
2003-01-27 23:36 UTC, Pedro Corte-Real 		none Details | Review

Description Pedro Corte-Real 2003-01-27 23:33:23 UTC 
shout2send and icecastsend connect and disconnect to servers in the wrong
pipeline state changes. The attatched patches make the behaviour follow
gstreamer/docs/random/wtay/states.

The shout2send patch also fixes a trivial compilation warning (missing
include of string.h) and changes the state change error case from g_error
to g_warning so as to not break the apps.

The icecastsend patch also removes a comment that doesn't make sense and
breaks a g_warning() line into 3.

These patches change behaviour visible to outside apps so I don't know if
they're 0.6.x material.
Comment 1 Pedro Corte-Real 2003-01-27 23:35:21 UTC 
Created attachment 13866 [details] [review]
Patch for shout2send
Comment 2 Pedro Corte-Real 2003-01-27 23:36:51 UTC 
Created attachment 13867 [details] [review]
Patch for icecastsend
Comment 3 Christian Fredrik Kalager Schaller 2003-02-23 20:55:20 UTC 
Commited to CVS head. Thanks Pedro.