GNOME Bugzilla – Bug 104569
both shout plugins do their (dis)connect on the wrong state change
Last modified: 2004-12-22 21:47:04 UTC
shout2send and icecastsend connect and disconnect to servers in the wrong pipeline state changes. The attatched patches make the behaviour follow gstreamer/docs/random/wtay/states. The shout2send patch also fixes a trivial compilation warning (missing include of string.h) and changes the state change error case from g_error to g_warning so as to not break the apps. The icecastsend patch also removes a comment that doesn't make sense and breaks a g_warning() line into 3. These patches change behaviour visible to outside apps so I don't know if they're 0.6.x material.
Created attachment 13866 [details] [review] Patch for shout2send
Created attachment 13867 [details] [review] Patch for icecastsend
Commited to CVS head. Thanks Pedro.