After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 104009 - [Solaris/0.6.1] gsta52dec.c can't be compiled
[Solaris/0.6.1] gsta52dec.c can't be compiled
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.5.1
Other opensolaris
: Normal normal
: 0.6.1
Assigned To: Brian Cameron
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-01-20 22:12 UTC by Jonas Jonsson
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.1/2.2


Attachments
I was hoping for someone to give a clean solution... Since noone did, here's my dirty hack. I don't want to be responsible for applying this. ;-). (794 bytes, patch)
2003-02-24 13:09 UTC, Ronald Bultje
none Details | Review

Description Jonas Jonsson 2003-01-20 22:12:40 UTC
The file includes <stdint.h>, that doesn't exist on a Solaris system (not
mine at least :) ....
The file is in ./ext/gsta52dec ....

By the way, it doesn't include config.h either, perhaps it should?
Comment 1 David I. Lehn 2003-01-22 19:04:43 UTC
Upstream checks for the C99 headers it uses and does some hack to
create similar ones if they are not available.  Perhaps to solve this
you might want to do the same... generate stdint.h header that uses
glib types.  I think it's mostly the [u]intN_t variety of typedefs
that are used.

Or better yet, just use a compiler that supports C99.
Comment 2 David I. Lehn 2003-01-22 19:06:04 UTC
A clarification: by "upstream" I mean the liba52 source.
Comment 3 Jonas Jonsson 2003-01-23 08:27:58 UTC
Hmm, I'm compiling this with gcc-3.2.1, doesn't it support C99?

And I still think that the configure script should notice that there
is no such file (stdint.h) and thus, it shouldn't be included.

JJ
Comment 4 Ronald Bultje 2003-01-31 00:17:50 UTC
It includes config.h now... If you remove the stdint.h,
uint8_t/uint32_t are undefined types... Choose your favourite
solution. ;).
Comment 5 Christian Fredrik Kalager Schaller 2003-02-24 12:13:19 UTC
Ronald, what is the status of this bug? is it fixed?
Comment 6 Ronald Bultje 2003-02-24 13:09:27 UTC
Created attachment 14577 [details] [review]
I was hoping for someone to give a clean solution... Since noone did, here's my dirty hack. I don't want to be responsible for applying this. ;-).
Comment 7 Ronald Bultje 2003-04-04 20:46:56 UTC
Since nobody else cares, I applied this to CVS with a #ifdef
HAVE_STDINT_H #include <stdint.h> #else <use above code> #endif.
Waiting for 0.6.1 approval.
Comment 8 Ronald Bultje 2003-04-07 17:00:35 UTC
Applied to 0.6.1 CVS.