After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 103342 - Use themed arrow for the menu button applet
Use themed arrow for the menu button applet
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
unspecified
Other All
: High minor
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 91321 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-01-13 04:21 UTC by Havoc Pennington
Modified: 2015-03-24 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshots (1.40 KB, image/png)
2003-01-13 22:54 UTC, Mark McLoughlin
  Details
patch (3.01 KB, patch)
2003-01-13 22:54 UTC, Mark McLoughlin
needs-work Details | Review
Updated patch (3.42 KB, patch)
2003-11-27 15:04 UTC, Vincent Untz
committed Details | Review

Description Havoc Pennington 2003-01-13 04:21:50 UTC
The menu button applet draws its own little white arrow, 
could use gtk_paint_arrow() instead, might match the 
theme better.
Comment 1 Mark McLoughlin 2003-01-13 21:56:55 UTC
Vincent: Havoc is refering to the tiny triangle on the Main Menu button
Comment 2 Mark McLoughlin 2003-01-13 21:57:13 UTC
*** Bug 91321 has been marked as a duplicate of this bug. ***
Comment 3 Mark McLoughlin 2003-01-13 22:51:43 UTC
Okay, so I did this and with the default theme its pratically
impossible to see. I'll attach a patch and a screenshot with the old
arrow and the new one (the old arrow is the one on the left)

Maybe the default theme should implement handling the shadow type and
the that would be a bit more obvious ?
Comment 4 Mark McLoughlin 2003-01-13 22:54:03 UTC
Created attachment 13543 [details]
screenshots
Comment 5 Mark McLoughlin 2003-01-13 22:54:16 UTC
Created attachment 13544 [details] [review]
patch
Comment 6 Havoc Pennington 2003-01-13 22:56:53 UTC
Two ideas are 1) adapt the foot icon to go with this,
overlap is bad even with current arrow and 2) draw the arrow slightly
larger.

The arrow should probably be larger anyway, people complain that the 
menu button isn't different enough from launchers.
Comment 7 Mark McLoughlin 2003-01-13 23:04:54 UTC
1) we use this for drawers as well
2) drawing the arrow larger sounds fine

... but I still think a shadow would be desirable, i.e. for the
default theme to handle the GtkShadowType passed in ...
Comment 8 Christian Kellner 2003-03-28 18:45:44 UTC
I am just removing the GNOMEVER2.1 keyword, because GNOMEVER2.3 is
allready set.
Comment 9 Kjartan Maraas 2003-04-22 15:35:48 UTC
So, has anyone been assigned the task of redrawing the foot icon? Tigert?
Comment 10 Vincent Untz 2003-11-27 15:04:24 UTC
Created attachment 21864 [details] [review]
Updated patch
Comment 11 Vincent Untz 2003-11-27 15:08:16 UTC
I updated Mark's patch. I made the arrow a bit bigger too.
Comment 12 alexander.winston 2004-01-21 06:52:32 UTC
Marking priority as high because of the updated patch.
Comment 13 Mark McLoughlin 2004-02-16 20:11:41 UTC
Tiny UI change, but a UI change non-the-less. Punting to 2.8
Comment 14 Mark McLoughlin 2004-05-13 08:20:36 UTC
2004-05-13  Mark McLoughlin  <mark@skynet.ie>
                                                                               
                                                               
        * button-widget.c: (calc_arrow), (button_widget_expose): use
        gtk_paint_arrow() to draw the little triangle on menu buttons
        rather than drawing a rectangle manually. Fixes bug #103342.