After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 103080 - Weather applet always defaults to using Pittsburgh as the weather station
Weather applet always defaults to using Pittsburgh as the weather station
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: gweather
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
: 89310 89692 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-01-11 07:47 UTC by Christian Rose
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4


Attachments
translatable default location patch (3.96 KB, patch)
2004-04-22 02:26 UTC, Gareth Owen
none Details | Review
updated patch (5.15 KB, patch)
2004-04-27 03:58 UTC, Gareth Owen
none Details | Review

Description Christian Rose 2003-01-11 07:47:08 UTC
Tested with the locale sv_SE.

The weather applet seems to always default to using the Pittsburgh weather
station.
That's probably nice for the original author and all that, but makes little
sense for current users all around the world.

Although not perfect, a better system would probably be to let the
translators specify a default for their language in the translations. This
is also the solution that Evolution uses.
Comment 1 John Fleck 2003-01-12 15:49:25 UTC
When you say "always defaults" do you mean that it does not remember
from session to session when you specify a new location?
Comment 2 Christian Rose 2003-01-12 18:13:37 UTC
No, I'm talking about the defaults here. "Always" as in "ignores what
would be sensible for my locale".
Comment 3 Kevin Vandersloot 2003-01-12 20:27:18 UTC
The defaults can be also be set with gconf. I think the applet should
prompt the user for a location when it is started instead of trying to
guess (which will be wrong anyways even if the country is correct)
Comment 4 Kevin Vandersloot 2003-03-11 19:09:25 UTC
*** Bug 89310 has been marked as a duplicate of this bug. ***
Comment 5 Kevin Vandersloot 2003-03-11 19:10:42 UTC
*** Bug 89692 has been marked as a duplicate of this bug. ***
Comment 6 Mårten Woxberg 2003-09-12 01:16:52 UTC
It's ok if it chooses the correct country because then you don't have
to scroll through the whole list. the Locations file doesn't even
contain all locations for my country (Sweden) so I've added those
relevant to me myself. But if it would default on Stockholm which is
the capital I wouldn't mind since I only change it once.. but having
the default of a 5 day forecast for Pittsburgh is totaly useless to me.

Default to the capital of each country if available is my suggestion.
Comment 7 Dennis Smit 2004-02-05 23:47:37 UTC
1.  Mårten Woxberg, we would love to have patches that add
    weather stations to the locations file, so please fill
    a bug and submit a patch!

2.  What would be a nice and clear way to let the translator
    choose the default city?, someone a suggestion?

Comment 8 Gareth Owen 2004-04-22 02:26:02 UTC
Created attachment 26947 [details] [review]
translatable default location patch

This patch allows the translator to choose a different default location by
adding 4 translatable strings.	These four strings should be set to the four
parameters in the Locations file for the choosen default city.

Basically all I did was make the current location defaults translatable (and
added some comments to tell the translator what is required)
Comment 9 Gareth Owen 2004-04-27 03:58:32 UTC
Created attachment 27134 [details] [review]
updated patch

I've updated the patch, so that it will now work if/when the location names are
marked for translation.
Comment 10 Kjartan Maraas 2004-04-28 20:08:53 UTC
Would be nice to get this in as soon as we branch.
Comment 11 Kevin Vandersloot 2004-05-16 13:46:05 UTC
Patch applied. Thanks a lot Gareth! Sorry for taking so long to review.