After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 102825 - add --enable-gtk=yes/no/auto
add --enable-gtk=yes/no/auto
Status: RESOLVED FIXED
Product: GConf
Classification: Deprecated
Component: gconf
1.2.x
Other All
: High normal
: GNOME2.6
Assigned To: GConf Maintainers
GConf Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-01-08 11:34 UTC by Julio Merino
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for configure.in to implement --with-gtk (1.61 KB, patch)
2004-02-12 17:35 UTC, Julio Merino
none Details | Review

Description Julio Merino 2003-01-08 11:34:46 UTC
As I see from the configure.in and Makefile's, GConf2 can be built without GTK. It seems to me that gtk is disabled when it is not found by the pkg-config stuff. This is right.

Although the user must have the ability to disable gtk support explicitly (with something like --disable-gtk), so that he can say "Yes, I have gtk installed, but I do not want GConf to use it".

Why, you may ask... It seems to me that GConf is an UI independant library, so I would like to (easily) remove the gtk dependancy in a package I'm maintaining (I'm currently trying it by patching configure...), but the patch is a hack and will become outdated on the next gconf release.
Comment 1 Havoc Pennington 2003-01-08 15:52:53 UTC
Seems reasonable. What I've done in other cases is 
--enable-gtk=[yes/no/auto] defaulting to auto, where 
if you specify yes it fails if gtk not found, if you specify no 
it never uses it.
Comment 2 Julio Merino 2003-01-08 16:04:04 UTC
That sounds good and more flexible :)
Comment 3 Julio Merino 2004-02-12 17:35:07 UTC
Created attachment 24363 [details] [review]
Patch for configure.in to implement --with-gtk
Comment 4 Julio Merino 2004-02-12 17:36:29 UTC
I've just added a patch that implements what you suggested, a 
tristate variable.  If it's auto, the default, configure will use 
gtk if found.  If set to yes, it will abort as soon as possible if 
gtk is missing.  And at last, if set to no, gtk won't be used at 
all. 
Comment 5 Mark McLoughlin 2004-04-19 11:06:28 UTC
I've committed a fixed up version of this to HEAD and gnome-2-6.

Changes I made were:

  + Used AC_ARG_ENABLE rather than AC_ARG_WITH
  + define DEPENDENT_WITH_XML_AND_GTK_CFLAGS/LIBS even when GTK isn't found
    or it won't build

Thanks :-)

2004-04-19  Mark McLoughlin  <mark@skynet.ie>
                                                                               
                                                               
        Based on a patch from Julio Merino <jmmv@hispabsd.org>
        in bug #102825
                                                                               
                                                               
        * configure.in: add a --enable-gtk=yes/no/auto (defaults to auto)