After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 102660 - WIndow menu shouldn't be affected by pointer position when popped up from keyboard
WIndow menu shouldn't be affected by pointer position when popped up from key...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: High normal
: ---
Assigned To: gtk-bugs
Metacity maintainers list
AP2
Depends on:
Blocks:
 
 
Reported: 2003-01-06 16:02 UTC by Calum Benson
Modified: 2011-02-04 16:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (463 bytes, patch)
2003-10-15 10:07 UTC, padraig.obriain
none Details | Review

Description Calum Benson 2003-01-06 16:02:56 UTC
From a recent review by a Sun beta tester:

"If Alt-Space is used to display the window menu and the pointer happens to
be placed where the menu opens, focus is assigned to that option.  This
behavior affects users (e.g. those who are blind) who rely on focus being
at a consistent location whenever the menu opens."

This doesn't seem to affect regular menubar menus so I'm guessing metacity
is doing something funky here.
Comment 1 Havoc Pennington 2003-01-06 17:41:38 UTC
I don't think metacity is doing anything funky, though I suppose 
it's possible there's some weird side effect of the menu being 
inside the WM.
Comment 2 Owen Taylor 2003-01-06 19:07:37 UTC
Have you tested with other menus? This is supposed
to work, and did work the last time I looked at it.
(A month or two ago)
Comment 3 Calum Benson 2003-01-06 19:14:01 UTC
I double-checked it on my (couple of week old) build from head before
I filed the bug... regular application dropdown and popup menus seemed
to correctly ignore the pointer when popped up from the keyboard, but
window menus didn't.
Comment 4 Havoc Pennington 2003-02-25 21:50:03 UTC
metacity will have a keyboard grab when the window menu comes up 
probably, from the XGrabKey(). Maybe that's related, dunno.
Comment 5 Owen Taylor 2003-02-25 22:28:39 UTC
keyboard grabs won't matter... hmm:

  /* If we are popping up the menu from something other than, a button
   * press then, as a heuristic, we ignore enter events for the menu
   * until we get a MOTION_NOTIFY.
   */

  current_event = gtk_get_current_event ();
  if (current_event)
    {
      if ((current_event->type != GDK_BUTTON_PRESS) &&
          (current_event->type != GDK_ENTER_NOTIFY))
        menu_shell->ignore_enter = TRUE;

      gdk_event_free (current_event);
    }

Possibly ignore_enter should be set in the !current_event
case.
Comment 6 Calum Benson 2003-04-03 14:30:28 UTC
Updating status_whiteboard field to reflect A11Y team's assessment 
of accessibility impact.
Comment 7 Calum Benson 2003-08-07 16:18:25 UTC
Apologies for spam... marking as GNOMEVER2.3 so it appears on the official GNOME
bug list :)
Comment 8 Havoc Pennington 2003-09-25 02:17:06 UTC
That gtk fix looks plausible; metacity is popping up the menu from an
event filter so I guess there's no current event.
Comment 9 padraig.obriain 2003-10-15 10:07:43 UTC
Created attachment 20719 [details] [review]
Proposed patch
Comment 10 padraig.obriain 2003-10-15 10:08:47 UTC
The proposed patch seems to fix the problem.
Comment 11 Owen Taylor 2003-11-11 16:31:57 UTC
Patch looks fine to apply, gtk-2-2 and HEAD.
Comment 12 padraig.obriain 2003-11-12 09:09:50 UTC
Patch applied to gtk-2-2 branch and HEAD.