After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 102576 - bogus keys in GHashNode
bogus keys in GHashNode
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other other
: Normal normal
: 0.4.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-01-05 12:09 UTC by Joshua N Pritikin
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix g_hash_table_insert calls in gstmemindex.c (893 bytes, patch)
2003-01-05 12:10 UTC, Joshua N Pritikin
none Details | Review
same patch for gstfileindex plus a few tweaks (2.10 KB, patch)
2003-01-05 17:02 UTC, Joshua N Pritikin
none Details | Review
same patch plus resolver fix (2.60 KB, patch)
2003-01-05 18:19 UTC, Joshua N Pritikin
none Details | Review

Description Joshua N Pritikin 2003-01-05 12:09:38 UTC
If you look at the ghash implementation, you will see that the key pointer
is stored in the GHashNode.

The attached patch fixes g_hash_table_insert calls in gstmemindex.c such
that the key remains valid for the duration of the hash table.

gstfileindex.c needs a similar patch which i can provide if needed.

Perhaps it would be worthwhile to grep the whole gstreamer tree for
g_hash_table_insert and verify that this problem does not exist anywhere else.
Comment 1 Joshua N Pritikin 2003-01-05 12:10:45 UTC
Created attachment 13358 [details] [review]
fix g_hash_table_insert calls in gstmemindex.c
Comment 2 Joshua N Pritikin 2003-01-05 17:02:59 UTC
Created attachment 13363 [details] [review]
same patch for gstfileindex plus a few tweaks
Comment 3 Joshua N Pritikin 2003-01-05 18:19:37 UTC
Created attachment 13364 [details] [review]
same patch plus resolver fix
Comment 4 Joshua N Pritikin 2003-01-06 02:59:06 UTC
wtay applied patch