After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 102565 - gstfileindex is borked
gstfileindex is borked
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other other
: Normal normal
: 0.4.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-01-05 10:28 UTC by Joshua N Pritikin
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix lots of fileindex bugs (9.24 KB, patch)
2003-01-05 10:30 UTC, Joshua N Pritikin
none Details | Review

Description Joshua N Pritikin 2003-01-05 10:28:52 UTC
The attached patch fixes the following problems:

+ gstfileindex tries to allocate writer_ids even if the index is empty
(reverse logic).

+ g_array_index didn't do what i expected.  Pass an explicit stride around
to  calculate record offsets.

+ Store index records in increasing order instead of decreasing.

+ Use temporaries for most GINT64_TO/FROM_BE macros.  This probably isn't
needed but it makes it easier to understand and debug.

+ Fix the indexers testsuite so it compiles again.  Pass memindex or
fileindex on the command line.

+ In cache1.c, compare actual results with expected results.
Comment 1 Joshua N Pritikin 2003-01-05 10:30:13 UTC
Created attachment 13357 [details] [review]
fix lots of fileindex bugs
Comment 2 Joshua N Pritikin 2003-01-05 17:01:17 UTC
committed by wtay