After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 102201 - GtkToolbar show_all/hide_all asymmetric
GtkToolbar show_all/hide_all asymmetric
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.2.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2002-12-30 07:47 UTC by Daniel Elstner
Modified: 2011-02-04 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (2.42 KB, patch)
2002-12-30 07:48 UTC, Daniel Elstner
none Details | Review

Description Daniel Elstner 2002-12-30 07:47:27 UTC
Calling gtk_widget_hide_all() followed by gtk_widget_show_all() on a
GtkToolbar leaves the toolbar's own children hidden.  The attached patch
fixes the problem by overriding GtkWidget::hide_all in addition to show_all.

(Yes, hide_all() is rarely used and just calling hide() instead gets around
the problem.  But I've seen problem reports about this and there's no real
reason for the asymmetry.)
Comment 1 Daniel Elstner 2002-12-30 07:48:29 UTC
Created attachment 13270 [details] [review]
proposed patch
Comment 2 Owen Taylor 2003-01-22 20:28:48 UTC
Looks fine to commit
Comment 3 Daniel Elstner 2003-01-23 19:48:27 UTC
Committed to HEAD.
Comment 4 Daniel Elstner 2003-01-23 20:02:19 UTC
Committed to gtk-2-2 too.