GNOME Bugzilla – Bug 102200
NautilusView leaking
Last modified: 2004-12-22 21:47:04 UTC
Quoting the initial mail of the thread: http://mail.gnome.org/archives/desktop-devel-list/2002-December/msg00555.html "I wonder how the lifecycle for a NautilusView is supposed to work. Third party views like gthumb image/catalog view or apotheke, which inherit from a NautilusView object, don't get destroyed properly when you switch back e.g. to a nautilus icon view. The most annyoing thing is that they left there possible merged menu/toolbar items (for apotheke you still have all your CVS commands in the menu)." It seems the problem lies in the NautilusViewFrame object, which doesn't free it's associeated view correctly. The attached patch works for me, which means that the views ar not lurking around anymore after shutting down nautilus and all the menus are correctly unmerged. I've set the severity to critical because the dead but unfree'd views are serious memory leaks.
Created attachment 13269 [details] [review] patch for NautilusViewFrame
*** Bug 92404 has been marked as a duplicate of this bug. ***
Hi Jens, it's not clear to me why you think we should do an extra remote unref here ? it _seems_ that we've done so already when we setup the view initially [ so as to ensure that the cnx. has only a single ref held on it ]; - this sucks obviously. It looks more likely to me - that things are not getting deactivated correctly [ if as you say menu items are hanging around forever ] - are you sure the ControlFrame is dying ?
*** Bug 99636 has been marked as a duplicate of this bug. ***
There was a refcount problem in nautilus_view_standard_main(). If you were using this function, it should be fixed now. If not, please reopen.
Thank you very much Dave. You fixed the most annoying bug for NautilusView users.