GNOME Bugzilla – Bug 102149
list does not refresh after "Save Theme" or installing a new theme
Last modified: 2005-02-28 14:41:49 UTC
Package: control-center Severity: normal Version: GNOME2.1.5 2.1.5 Synopsis: list does not refresh after "Save Theme" Bugzilla-Product: control-center Bugzilla-Component: theme-manager Description: When you save a theme it does not appear in the list until after you restart the theme applet. It would be better if the list was refreshed after saving a theme. ------- Bug moved to this database by unknown@bugzilla.gnome.org 2002-12-29 07:06 ------- Reassigning to the default owner of the component, control-center-maint@bugzilla.gnome.org.
TARGET2.2.x, plainly a usability bug
Just to clarify - although this has the TARGET2.2.0 keyword for now, it is a Would Be Nice for 2.2.0 and not a release-blocker. I'm lobbying for a TARGET2.2.x keyword.
It doesn't refresh when installing a new theme either, this is what bug 102217 is about (marking as dup)
*** Bug 102217 has been marked as a duplicate of this bug. ***
Fixed in 2.1.7
*** Bug 106591 has been marked as a duplicate of this bug. ***
Bug 106591 reports this bug in version 2.2.0.1.
When we install a new meta theme the list is not refreshed once its installed, hence the new meta theme will not be displayed in the list until the capplet is killed and launched again. Am attaching a patch which refreshes the theme list once a new theme is installed and it fixes the problem.
Created attachment 14467 [details] [review] Patch as stated above.
Cleaning up keywords. Anyone care to review this?
Maybe better to reread the themes from disk one time in the function that calls the two callbacks instead of one time for each?
Hi Kjartan, The callbacks are attached using g_idle_add() and are executed when there are no high priority tasks pending. The new theme is untarred/unzipped and installed in the callback functions, and only after this we should call gnome_theme_details_reread_themes_from_disk() to read the newly installed theme. Hence we need this reread API to be called in the the callbacks rather than in the function that attaches these callbacks. Thanks.
I think the original patch didn't work for me when I tested it.
Hi Kjartan, I rechecked the patch and it works fine. Can you pls. check it again and let me know if it's okay to commit. Thanks.
I'll take it for another spin.
I just tried this by downloading the first theme (gtk2) from art.gnome.org and I still don't see it updating the list under "Details" ->"Controls". Maybe you could give me clearer instructions on how to test the patch if this is wrong.
Hi Kjartan, Tried it out with the latest Gnome build from HEAD and I find that it isn't working. On further analysis I find that gnome_theme_details_reread_themes_from_disk() in the patch recreates the theme list after installing the theme but it's not been updated with the newly installed theme, one of the reason I could think of is gtk2/metacity/..._dir_changed() in gnome-theme-info.c is not been called by gnome_vfs for the changes in the theme directory which it should monitor. The same was working when I first created the patch, not sure what has been changed by then, would need to dig further... Also am removing the PATCH keyword for now. Thanks.
I also submitted this bug 2004-06-07 (#143904). For some reason, famd was not running, it refreshes if you run this. However, I still think theme-manager should not rely on famd because you are actually installing it in the same program, some people might miss this.
*** Bug 143904 has been marked as a duplicate of this bug. ***
seems to work fine here, do you still have this issue ?
It doesn't work for me if I do this: - add a widget theme - add a border theme - add an icon theme - try to create a custom theme of these three I can see the newly installed widget and border themes, but not the icon theme after calling the function in the patch here in transfer_done_cb() Maybe we need to call it in more than one place? Or maybe the code in gnome_theme_details_reread_themes_from_disk() needs fixing in the icon theme case?
*** Bug 108366 has been marked as a duplicate of this bug. ***
Should be working with the latest gnome-control-center release. 2.9.92 or something. Or with CVS. Can anyone confirm this?
As I explained in bug #102216, I tried to install a new metacity theme by dragging a package on the "details" window, and it did not show in the list. I had to exit and restart to see the new theme.
This works for me in 2.9.91, I'm going to close. Vincent or others, can you reopen if you still see it?