After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 100078 - looking for icon theme in wrong prefix
looking for icon theme in wrong prefix
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] theme-manager
2.1.x
Other Linux
: High normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 100720 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-12-01 22:39 UTC by Mark Finlay
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.1/2.2


Description Mark Finlay 2002-12-01 22:39:39 UTC 
I've used garnome to install gnome 2.3.1 installed into /storage/garnome 

I can change icon themes manually with gconf to any of the themes in
/storage/garnome/share/icons - but in the theme applet the icon themes
in /usr/garnome/share/icons are listed instead.

Not sure if this is a garnome bug or a control center bug
Comment 1 Christian Neumair 2002-12-02 21:45:41 UTC 
OK, could verify it:
it's a gnome-control-center bug.
...
  icon_themes_add_dir ("/usr/share/icons");
...
(common/gnome-theme-info.c, l. 397)
Any comments on that?
How should we solve it?
My proposal is renaming this file from .c to .c.in and generating that
at configure time.

regs,
 Chris
Comment 2 Andrew Sobala 2002-12-02 22:57:12 UTC 
Can't you just use a preprocessor macro?
Comment 3 Andrew Sobala 2002-12-09 19:22:20 UTC 
*** Bug 100720 has been marked as a duplicate of this bug. ***
Comment 4 Mark Finlay 2002-12-26 18:41:26 UTC 
What is done for the metacity and gtk theme tabs? couldn't the code 
just be reused from there?

And does whoever is working on the themes applet atm know about this
bug?
Comment 5 Seth Nickell 2002-12-27 23:32:55 UTC 
Metacity and GTK are using gtk_rc_get_theme_dir, which is going to be
based off the run-time location of the GtkRC theme directory. The
problem with icon themes is that they aren't rooted in the theme
directory in the same way (its a shame, but that's how it goes).
Consequently, we'll need different code.
Comment 6 Mark Finlay 2002-12-28 11:11:47 UTC 
I think that icons should be in PREFIX/share/themes too, to make it
easier to make proper metathemes in the first place. In this case the
control center would need very little modification, but the code that
implements icon themes would need to be tweaked, along with the
makefiles for gnome-icon-theme.

And because this is the first stable release with icon themes it is
important to decide the permanent location for them now.
Comment 7 Andrew Sobala 2002-12-28 11:21:43 UTC 
They _should_ be in $PREFIX/share/themes. But they're not, and to move
them now would be breaking the icon theme specification.
Comment 8 Mark Finlay 2002-12-28 11:49:02 UTC 
Well maybe we should look to having the *draft* specification fixed
before we ship. Since we are the first ppl(appart from rh8) to ship it
I can't see that it would be impossible to do.
Comment 9 Seth Nickell 2002-12-28 23:55:17 UTC 
I've changed the capplet to work as per the freedesktop icon spec for
now (esp. since that's what all the other pieces of GNOME are using).
If you want this changed, time to push on freedesktop is *now*.
Comment 10 Mark Finlay 2002-12-29 21:02:24 UTC 
I've updated from CVS and the applet is still not picking up
the accesibility or gnome icon themes in PREFIX/usr/share
Comment 11 Mark Finlay 2002-12-29 21:35:31 UTC 
Don't mind me. Sorry about the Spam. It is working.