After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 76522 - Add equalizer support
Add equalizer support
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: Plugins (other)
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 342453 354635 387375 398147 439650 550820 590935 646598 649744 (view as bug list)
Depends on: 345181 415627
Blocks:
 
 
Reported: 2002-03-26 22:58 UTC by Seth Nickell
Modified: 2018-05-24 08:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Implementation of an equalizer widget (8.31 KB, application/x-gzip)
2006-08-16 16:45 UTC, Christophe Dehais
  Details
Screencast of the equalizer widget (144.54 KB, application/ogg)
2006-09-07 16:24 UTC, Christophe Dehais
  Details
patch for an equalizer plugin (126.41 KB, patch)
2007-02-15 22:30 UTC, Christophe Dehais
none Details | Review
various minor updates (118.66 KB, patch)
2007-02-28 10:27 UTC, Jonathan Matthew
none Details | Review
more minor fixes (117.50 KB, patch)
2007-03-01 13:27 UTC, Jonathan Matthew
none Details | Review
Merging with current advancements (117.89 KB, patch)
2007-03-02 23:14 UTC, Christophe Dehais
none Details | Review
Merging with current advancements - take 2 (119.04 KB, patch)
2007-03-02 23:53 UTC, Christophe Dehais
none Details | Review
updated version of the EQ (118.56 KB, patch)
2007-11-13 05:30 UTC, Dorian Scholz
none Details | Review
Now with less crashing (119.05 KB, patch)
2008-05-20 01:57 UTC, John Millikin
none Details | Review
Updated for SVN 5823 (119.36 KB, patch)
2008-07-28 22:55 UTC, John Daiker
none Details | Review

Description Seth Nickell 2002-03-26 22:58:45 UTC
Add equalizer support to MonkeySound
Comment 1 Loïc Minier 2004-10-13 16:00:29 UTC
This is Debian bug http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=229030
Comment 2 James "Doc" Livingston 2006-01-26 01:03:14 UTC
This should be easy enough to do with GStreamer, as there is an equaliser element. 
Comment 3 Alex Lancaster 2006-01-28 12:45:22 UTC
Remove target milestone 0.4 is long past...
Comment 4 Dennis Cranston 2006-04-13 05:55:05 UTC
Well, I was about to add a similar bug to bugzilla.  This would be a very nice feature.   
Comment 5 Alex Lancaster 2006-04-13 07:18:39 UTC
Would probably be now done as a plugin.  Changing component.
Comment 6 Jonathan Matthew 2006-05-21 00:06:40 UTC
*** Bug 342453 has been marked as a duplicate of this bug. ***
Comment 7 Jonathan Matthew 2006-05-21 00:08:03 UTC
Bug 342453 also mentioned the idea of mapping genres to particular equalizer settings.
Comment 8 Christophe Dehais 2006-08-16 16:45:28 UTC
Created attachment 71022 [details]
Implementation of an equalizer widget

Attached an implementation of a widget that could control an equalizer filter in the playback backend.

It can load presets from a file, edit them and save them back. There is a support for localization.

Feel free to try it out and send comments and patches.
Comment 9 James "Doc" Livingston 2006-08-17 01:41:20 UTC
Marking this as dependent on bug 345181.
Comment 10 Jonathan Matthew 2006-09-01 11:10:12 UTC
Looks sensible enough to me.  However:
- how does one create a new preset?
- I don't think the checkbox label should change; it should just be 'enabled' or something

For this to be useful, there'd need to be a 'band-changed' signal on the RBEqualizer class, so the plugin (or whatever) using it could modify the gst equalizer element's settings when the user changes the EQ.
Comment 11 Sergej Kotliar 2006-09-06 15:09:07 UTC
*** Bug 354635 has been marked as a duplicate of this bug. ***
Comment 12 Christophe Dehais 2006-09-07 16:24:07 UTC
Created attachment 72382 [details]
Screencast of the equalizer widget

Attached a screencast showing the equalizer widget in action.

iTunes does something different to create a new preset. As soon as the user changes a band, the combo box switches to "user defined". Then when she hit "save" she's asked to enter a name. A list view of all presets allows to rename or delete them.

I think what's important is to avoid confirmation dialogs (do you want to overwrite ? do you want to delete ? do you want to discard changes ?) that are quickly annoying in this context.
Comment 13 Alex Lancaster 2006-12-19 03:18:28 UTC
*** Bug 387375 has been marked as a duplicate of this bug. ***
Comment 14 Jonathan Matthew 2007-01-18 21:59:16 UTC
*** Bug 398147 has been marked as a duplicate of this bug. ***
Comment 15 Christophe Dehais 2007-02-15 22:30:08 UTC
Created attachment 82638 [details] [review]
patch for an equalizer plugin

So here is a plugin for adding an equalizer widget to RB, which itself will control a GStreamer filter inserted into the pipeline.

That means the plugin needs the patch found in Bug 345181, which works but is not yet complete. One limitation for the equalizer is that it's always active (even when turned off in the UI).

The plugin is done to work with the 3 gst elements: equalizer (currently in gst-bad CVS), ladspa-tap-equalizer and laspa-Eq (formerly in gst-good, now in gst-bad). It detects which ones are present on the system and a particular one can be forced by editing the eq-config.ini file (the preferences dialog actually does nothing for this).
At the moment, each filter is associated with a default configuration (in terms of number of bands and frequencies setting), but the plan is to make it configurable (the boilerplate code for that is there, I'm still thinking about the UI).
Comment 16 Jonathan Matthew 2007-02-28 10:27:35 UTC
Created attachment 83536 [details] [review]
various minor updates

Fixes various build problems and some code style things, removes the marshaller list (just use rb-marshal.list).  I also changed the plugin name from "Equalizer Plugin" to just "Equalizer" - that only appears in the plugin list, where it's already obvious that it's a plugin.
Comment 17 Jonathan Matthew 2007-03-01 13:27:12 UTC
Created attachment 83636 [details] [review]
more minor fixes

- use gtk_window_set_transient_for rather than watching the main window's visibility
- change the 'show equalizer' action into a toggle
Comment 18 Alex Lancaster 2007-03-02 13:39:56 UTC
Hmm, got it to build but it crashes rhythmbox when I attempt to enable the plugin.  I'm using CVS of gstreamer and plugins.

System: Linux 2.6.19-1.2911_1.fc6.cubbi_suspend2 #1 SMP Thu Feb 15 09:43:48 CET 2007 i686
X Vendor: The X.Org Foundation
X Vendor Release: 70101000
Selinux: No
Accessibility: Disabled

Memory status: size: 244244480 vsize: 0 resident: 244244480 share: 0 rss: 49205248 rss_rlim: 0
CPU usage: start_time: 1172842618 rtime: 0 utime: 726 stime: 0 cutime:697 cstime: 0 timeout: 29 it_real_value: 0 frequency: 23

Backtrace was generated from '/home/alex/bin/rhythmbox'

Using host libthread_db library "/lib/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread -1209215264 (LWP 15511)]
[New Thread -1320608880 (LWP 15564)]
[New Thread -1362568304 (LWP 15561)]
[New Thread -1352078448 (LWP 15530)]
[New Thread -1341588592 (LWP 15529)]
[New Thread -1331098736 (LWP 15528)]
[New Thread -1275376752 (LWP 15527)]
[New Thread -1299158128 (LWP 15526)]
[New Thread -1310119024 (LWP 15523)]
0x00959402 in __kernel_vsyscall ()

Thread 1 (Thread -1209215264 (LWP 15511))

  • #0 __kernel_vsyscall
  • #1 waitpid
    from /lib/libpthread.so.0
  • #2 gnome_gtk_module_info_get
    from /usr/lib/libgnomeui-2.so.0
  • #3 <signal handler called>
  • #4 rb_plugin_find_file
    at /home/alex/src/remote-cvs/gnome.org/rhythmbox/plugins/rb-plugin.c line 258
  • #5 impl_activate
    at /home/alex/src/remote-cvs/gnome.org/rhythmbox/plugins/equalizer/rb-equalizer-plugin.c line 497
  • #6 rb_plugin_activate
    at /home/alex/src/remote-cvs/gnome.org/rhythmbox/plugins/rb-plugin.c line 153
  • #7 rb_plugins_engine_activate_plugin
    at /home/alex/src/remote-cvs/gnome.org/rhythmbox/plugins/rb-plugins-engine.c line 487
  • #8 plugin_manager_set_active
    at /home/alex/src/remote-cvs/gnome.org/rhythmbox/plugins/rb-plugin-manager.c line 263
  • #9 plugin_manager_toggle_active
    at /home/alex/src/remote-cvs/gnome.org/rhythmbox/plugins/rb-plugin-manager.c line 302
  • #10 active_toggled_cb
    at /home/alex/src/remote-cvs/gnome.org/rhythmbox/plugins/rb-plugin-manager.c line 148
  • #11 g_cclosure_marshal_VOID__STRING
    from /lib/libgobject-2.0.so.0
  • #12 g_closure_invoke
    from /lib/libgobject-2.0.so.0
  • #13 g_signal_chain_from_overridden
    from /lib/libgobject-2.0.so.0
  • #14 g_signal_emit_valist
    from /lib/libgobject-2.0.so.0
  • #15 g_signal_emit
    from /lib/libgobject-2.0.so.0
  • #16 gtk_cell_renderer_toggle_activate
    at gtkcellrenderertoggle.c line 402
  • #17 IA__gtk_cell_renderer_activate
    at gtkcellrenderer.c line 605
  • #18 gtk_tree_view_column_cell_process_action
    at gtktreeviewcolumn.c line 2846
  • #19 _gtk_tree_view_column_cell_event
    at gtktreeviewcolumn.c line 3123
  • #20 gtk_tree_view_button_press
    at gtktreeview.c line 2543
  • #21 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 84
  • #22 g_value_set_static_boxed
    from /lib/libgobject-2.0.so.0
  • #23 g_closure_invoke
    from /lib/libgobject-2.0.so.0
  • #24 g_signal_chain_from_overridden
    from /lib/libgobject-2.0.so.0
  • #25 g_signal_emit_valist
    from /lib/libgobject-2.0.so.0
  • #26 g_signal_emit
    from /lib/libgobject-2.0.so.0
  • #27 gtk_widget_event_internal
    at gtkwidget.c line 3915
  • #28 IA__gtk_propagate_event
    at gtkmain.c line 2335
  • #29 IA__gtk_main_do_event
    at gtkmain.c line 1569
  • #30 gdk_event_dispatch
    at gdkevents-x11.c line 2318
  • #31 g_main_context_dispatch
    from /lib/libglib-2.0.so.0
  • #32 g_main_context_check
    from /lib/libglib-2.0.so.0
  • #33 g_main_loop_run
    from /lib/libglib-2.0.so.0
  • #34 IA__gtk_main
    at gtkmain.c line 1148
  • #35 main
    at /home/alex/src/remote-cvs/gnome.org/rhythmbox/shell/main.c line 383
  • #0 __kernel_vsyscall


----------- .xsession-errors (535211 sec old) ---------------------
localuser:alex being added to access control list
warning: /etc/X11/xinit/xinitrc.d/sonypid does not end in .sh extension, ignoring
non-network local connections being added to access control list
--------------------------------------------------
Comment 19 Alex Lancaster 2007-03-02 13:43:46 UTC
debug output:

(06:42:53) [0x8638410] [rb_module_init] /home/alex/src/remote-cvs/gnome.org/rhythmbox/plugins/rb-module.c:132: RBModule 0x8a69b80 initialising
(06:42:53) [0x8638410] [rb_module_load] /home/alex/src/remote-cvs/gnome.org/rhythmbox/plugins/rb-module.c:64: Loading /usr/local//lib/rhythmbox/plugins/equal
izer/libequalizer.so
(06:42:53) [0x8638410] [register_rb_plugin] /home/alex/src/remote-cvs/gnome.org/rhythmbox/plugins/equalizer/rb-equalizer-plugin.c:108: Registering plugin RBE
qualizerPlugin
(06:42:53) [0x8638410] [rb_module_new_object] /home/alex/src/remote-cvs/gnome.org/rhythmbox/plugins/rb-module.c:117: Creating object of type RBEqualizerPlugi
n
(06:42:53) [0x8638410] [rb_equalizer_plugin_init] /home/alex/src/remote-cvs/gnome.org/rhythmbox/plugins/equalizer/rb-equalizer-plugin.c:137: RBEqualizerPlugi
n initialising
(06:42:53) [0x8638410] [rb_plugin_find_file] /home/alex/src/remote-cvs/gnome.org/rhythmbox/plugins/rb-plugin.c:255: found '(null)' when searching for file 'e
q-config.ini' for plugin 'equalizer'
Comment 20 Alex Lancaster 2007-03-02 13:59:18 UTC
OK works now, problem was, .ini files weren't being installed to <prefix>/lib/rhythmbox/plugins/equalizer
Comment 21 Christophe Dehais 2007-03-02 23:08:38 UTC
(In reply to comment #17)
> Created an attachment (id=83636) [edit]
> more minor fixes
> 
> - use gtk_window_set_transient_for rather than watching the main window's
> visibility
> - change the 'show equalizer' action into a toggle
> 

Thanks for the cleanups.

By the way, why did you exported the GtkTreeStore columns enum to the rb-equalizer.h ? It's really only use in the widget implementation.
Comment 22 Christophe Dehais 2007-03-02 23:14:58 UTC
Created attachment 83768 [details] [review]
Merging with current advancements

- add updated rb-marshall.lst
- some preference UI refinements
- more on gstreamer filter configuration UI (still far from finished)
Comment 23 Jonathan Matthew 2007-03-02 23:40:26 UTC
> By the way, why did you exported the GtkTreeStore columns enum to the
> rb-equalizer.h ? It's really only use in the widget implementation.

It was already like that in the first version of the patch I looked at.
Comment 24 Christophe Dehais 2007-03-02 23:48:24 UTC
(In reply to comment #23)
> > By the way, why did you exported the GtkTreeStore columns enum to the
> > rb-equalizer.h ? It's really only use in the widget implementation.
> 
> It was already like that in the first version of the patch I looked at.
> 

ok I'm stupid :). Moving it to the .c


Comment 25 Christophe Dehais 2007-03-02 23:53:27 UTC
Created attachment 83775 [details] [review]
Merging with current advancements - take 2

Forgot a file, a line and that:
- on/off check box is functionnal, but it makes RB hangs (on removal). It's related to Bug 345181 (or the way I use it)
Comment 26 Stefan Sauer (gstreamer, gtkdoc dev) 2007-03-07 08:30:55 UTC
before you rely too much on the equalizer as it is in -bad. the interface will change (see #415627).
Comment 27 Alex Lancaster 2007-03-07 10:47:32 UTC
Make this bug dependent on bug #415627.
Comment 28 Christophe Dehais 2007-03-07 12:41:45 UTC
(In reply to comment #26)
> before you rely too much on the equalizer as it is in -bad. the interface will
> change (see #415627).
> 

yes, of course. In the meantime, the plugin can also use the ladspa equalizers (thought they may also be moving targets since they are in -bad too).
Comment 29 Stefan Sauer (gstreamer, gtkdoc dev) 2007-03-08 07:12:58 UTC
It would be nice if you could comment on bug #415627. The plan is to have a 3band and 10band versions which has normal gobject properties. Is that something the would fit rb (e.g. the 10 band one)?

And before you think about adding preset support for the eq, have a look a bug #396779.
Comment 30 Christophe Dehais 2007-03-08 09:27:30 UTC
(In reply to comment #29)
> It would be nice if you could comment on bug #415627. The plan is to have a
> 3band and 10band versions which has normal gobject properties. Is that
> something the would fit rb (e.g. the 10 band one)?

With the current design of the plugin I don't think having those 2 elements will bring anything. Indeed, I would have to add 2 more specific callbacks (to link gst element to the UI) for something that I can have by simply parameterizing the general version of the filter. What would help (for the beauty of the client code), would be a way to retrieve the bands frequencies onccec the number of bands has been given. Right now I mimick what is done internally by the filter.


> And before you think about adding preset support for the eq, have a look a bug
> #396779.
> 

The UI part of the plugin was started last summer and I then didn't know there was a plan for adding presets right in the gstreamer elements. So it's already there. I think centralizing preset is a good idea, it will remove some burden off my code. I'll look into bug #396779 to see if the proposal can fit this use case.
Comment 31 Jonathan Matthew 2007-05-20 05:02:13 UTC
*** Bug 439650 has been marked as a duplicate of this bug. ***
Comment 32 Stefano Pedretti 2007-05-30 16:07:09 UTC
Something moving about? There's no way to have a sound equalizer for the next release of gnome? Good work!
Comment 33 Christophe Dehais 2007-08-25 09:32:47 UTC
Unfortunately I have no time atm to bring the plugin to the quality required for shipping it with RB. There's not much left to do, mainly:
- verify that it's up to date wrt current gstreamer.
- handle deactivation.
- store the configuration in gconf instead of an ini file.
Comment 34 Jakub 'Livio' Rusinek 2007-09-29 15:24:25 UTC
I propose two options for equalizer: SRS WOW (echo like) and TruBass (just bass).
http://bugzilla.gnome.org/show_bug.cgi?id=473193
Comment 35 Stefan Sauer (gstreamer, gtkdoc dev) 2007-09-29 17:31:48 UTC
Jakub,
I don't think the SRS WOW effect is related to equalizer support. The TrueBass sounds like its just a presets that attenuates the bass a bit.
Comment 36 Dorian Scholz 2007-11-13 05:30:30 UTC
Created attachment 99005 [details] [review]
updated version of the EQ

I just tried out the patch and made some adjustments to get it working again with the current svn version of rhythmbox and GStreamer 0.10.14.
I had to replace the old gst plugin 'equalizer' with the new 'equalizer-nbands' and fixed the corresponding 'equalizer_band_changed_cb' method.
It is working like this, but the sound is not to great when playing around with the EQ. And the EQ 'on' check box crashes the whole RB...
So I hope this motivates someone to continue working on this. At least now you can use this patch and get a 'working' EQ again...
As it looks from the gstreamer bug mentioned on this page, the gst equalizer plugin will be move from 'bad' to 'good' in the next release package! So hopefully the API will stay stable now.
Really looking forward to see this fully working soon ;-)
Unfortunately I don't have the time to finish this right now...
Good Luck
Comment 37 Sebastian Dröge (slomo) 2007-11-13 12:32:57 UTC
The equalizer API is meant to be stable now and hopefully the equalizer will be in gst-plugins-good 0.10.7 soonish.
Comment 38 Christophe Dehais 2007-11-17 23:09:41 UTC
Got several things not working as they used to. I'll try to investigate this week.
Comment 39 Christophe Dehais 2007-11-21 00:20:56 UTC
Ok, I looked at it. 
It seems that either Rhythmbox or Gstreamer has a problem, because even removing an "identity" element while playing hangs RB; E.g if I do that in the python console:

[first start a song]
>> import gst
>> i = gst.element_factory_make ("identity")
>> shell.props.shell_player.props.player.add_filter(i)
>> shell.props.shell_player.props.player.remove_filter(i)

RB hangs.
From early investigation, it seems the call to incriminate is gst_element_set_state() (setting the filter-bin state to NULL, see function rb_player_gst_remove_filter() from rb-player-gst.c). It might indicate a gstreamer bug, but I don't really know or have much time to go further along.

I'm using gstreamer 0.10.14.

Also the RB playbin doesn't like adding any LADSPA filters while playing (I would add: anymore, but again it might be gstreamer's fault).
Comment 40 Stefan Sauer (gstreamer, gtkdoc dev) 2007-11-21 07:30:48 UTC
Christophe, in buzztard I have a tee element for dynamicanalyzers (like spectrum analyzer). To be able to insert a element while playing one has to follow the rules in 
http://webcvs.freedesktop.org/gstreamer/gstreamer/docs/design/part-block.txt?view=markup

This is unfortunately. I made a first attempt to provide a dynamic linking API in Bug 435487, but it has not been reviewed/tested :(.
Comment 41 Милош Поповић 2008-03-05 16:34:23 UTC
I have a crash when activateing plugin.
Gentoo Linux, Gnome 2.20, Rhythmbox 0.11.3, Gstreamer 0.10.17, gst-plugins-good 0.10.7.

Crash message (not very helpfull)
(rhythmbox:9139): Rhythmbox-WARNING **: could not load equalizer config file

Segmentation fault
Comment 42 Andrew Conkling 2008-03-05 16:45:46 UTC
(In reply to comment #41)
> Crash message (not very helpfull)
> (rhythmbox:9139): Rhythmbox-WARNING **: could not load equalizer config file
> 
> Segmentation fault

Could you run Rhythmbox to get some output, something like 'rhythmbox -d' (which will probably generate a LOT of extraneous output) or 'rhythmbox -D equalizer' or similar ("equalizer" should be the name of the plugin, but I'm not sure what that is).

If you get a lot of output, maybe you could attach it as a text file to the bug?
Comment 43 Bastien Nocera 2008-03-05 16:51:51 UTC
It's a bogus error. The warning is causing the crash, because G_FATAL_WARNINGS is turned on. It should use g_printerr() instead of a g_warning for something that's not a programming error.
Comment 44 Милош Поповић 2008-03-05 22:22:40 UTC
(23:19:55) [0x80c4028] [rb_module_load] rb-module.c:64: Loading /usr/lib/rhythmbox/plugins/equalizer/libequalizer.so
(23:19:56) [0x80c4028] [register_rb_plugin] rb-equalizer-plugin.c:112: Registering plugin RBEqualizerPlugin
(23:19:56) [0x80c4028] [rb_module_new_object] rb-module.c:117: Creating object of type RBEqualizerPlugin
(23:19:56) [0x80c4028] [rb_equalizer_plugin_init] rb-equalizer-plugin.c:141: RBEqualizerPlugin initialising
(23:19:56) [0x80c4028] [rb_plugin_find_file] rb-plugin.c:255: found '(null)' when searching for file 'eq-config.ini' for plugin 'equalizer'

(rhythmbox:17812): GLib-CRITICAL **: g_key_file_load_from_file: assertion `file != NULL' failed

(rhythmbox:17812): Rhythmbox-WARNING **: could not load equalizer config file

(23:19:56) [0x80c4028] [make_equalizer_element] rb-equalizer-plugin.c:492: Trying to make filter element: (null)
(23:19:56) [0x80c4028] [get_available_filters] rb-equalizer-plugin.c:476: Equalizer filter equalizer-nbands present
(23:19:56) [0x80c4028] [get_available_filters] rb-equalizer-plugin.c:476: Equalizer filter ladspa-tap-equalizer not present
(23:19:56) [0x80c4028] [get_available_filters] rb-equalizer-plugin.c:476: Equalizer filter ladspa-Eq not present
Segmentation fault


I just installer ladspa gstreamer support but nothing changed.
Comment 45 Милош Поповић 2008-03-05 23:42:57 UTC
Same problem with Rhythmbox 0.11.4. Damn it...
Comment 46 Jonathan Matthew 2008-03-06 00:10:08 UTC
The problem is in the equalizer plugin code.  You're welcome to fix it.
Comment 47 Милош Поповић 2008-03-06 20:58:23 UTC
I would if i could :) I am not a coder. Any help?
Comment 48 Christophe Dehais 2008-03-06 23:03:36 UTC
I have an update in the pipeline for the plugin, if you can wait a little hopefully it'll solve the problem (and others).
Comment 49 Милош Поповић 2008-03-06 23:19:23 UTC
...would be great. Thanks.
Comment 50 Jakub 'Livio' Rusinek 2008-04-10 16:21:40 UTC
Stefan (comment #35): but TrueBass is independent from equalizer, allowing to increase bass few times more even when EQ enabled.
Comment 51 John Millikin 2008-05-20 01:57:44 UTC
Created attachment 111195 [details] [review]
Now with less crashing

Tweaked version. Instead of just crashing when the config file can't be loaded, defaults to the "equalizer-nbands" filter element. Also, disable the "Configure" button if the plugin can't be loaded. Is there any way to return an error value from a C plugin's loading function?
Comment 52 John Daiker 2008-07-28 22:55:29 UTC
Created attachment 115461 [details] [review]
Updated for SVN 5823

An argument to g_key_file_get_groups() needed to be a gsize instead of a guint.
Comment 53 Jonathan Matthew 2008-11-10 11:24:20 UTC
Has anyone compared this equalizer patch with the one attached to bug 550820?
Comment 54 Jonathan Matthew 2008-12-17 11:29:27 UTC
*** Bug 550820 has been marked as a duplicate of this bug. ***
Comment 55 chuchiperriman 2009-02-03 15:47:25 UTC
What about this bug? Will be developed/inserted into rythmbox on 2.26 or 2.28?
Comment 56 mva.led 2009-07-22 03:10:10 UTC
It's being now a long time since the plugin for gstreamer was implemented. 

Does anybody keeps working on this for RB? What is needed to finish it? Can I help anyhow?

Best regards,
Manuel.
Comment 57 Jonathan Matthew 2009-08-06 12:07:50 UTC
*** Bug 590935 has been marked as a duplicate of this bug. ***
Comment 58 Scott Lewin 2009-10-30 15:10:54 UTC
+1 An equalizer would be a huge addition to Rythmbox and make it usable by many.
Comment 59 Javed 2010-03-14 23:18:22 UTC
Any time-line as to when we get this equalizer support on RB?
Comment 60 Jakub 'Livio' Rusinek 2010-03-14 23:21:48 UTC
Move to an other media player. Rhythmbox is dead.
Comment 61 Jonathan Matthew 2010-03-14 23:52:19 UTC
(In reply to comment #59)
> Any time-line as to when we get this equalizer support on RB?

When there is an equalizer plugin that actually works and has a suitable UI, I'll consider it.  I'm probably not going to work on it myself as it's very low on my list of priorities.

(In reply to comment #60)
> Move to an other media player. Rhythmbox is dead.

If you're dissatisfied, the classy thing to do would be to quietly remove yourself from the cc list.  Comments like this don't help anyone.
Comment 62 Bastien Nocera 2010-03-15 00:03:13 UTC
(In reply to comment #61)
> (In reply to comment #60)
> > Move to an other media player. Rhythmbox is dead.
> 
> If you're dissatisfied, the classy thing to do would be to quietly remove
> yourself from the cc list.  Comments like this don't help anyone.

And consider this a first warning before you're barred from the GNOME Bugzilla, you should know better than making this sort of comment here.
Comment 63 Javed 2010-03-31 14:27:16 UTC
http://cornerofseven.com/blog/2010/02/rbeq-1-3-now-with-presets/

Looks like this guy has built it. If it is good enough can it be added to rb by default?
Comment 64 Stefan Sauer (gstreamer, gtkdoc dev) 2010-03-31 19:18:58 UTC
(In reply to comment #63)
> http://cornerofseven.com/blog/2010/02/rbeq-1-3-now-with-presets/
> 
> Looks like this guy has built it. If it is good enough can it be added to rb by
> default?

This one is using a self cooked preset mechanism. I left this comment on the blog:
  "Any reason, you are not using the presets shipped with the gstreamer plugin?
Look at /usr/share/gstreamer-0.10/presets/GstIirEqualizer10Bands.prs and the GstPreset interface. Users can install own presets to $HOME/.gstreamer-0.10/presets/"
Comment 65 Jonathan Matthew 2011-04-03 06:15:21 UTC
*** Bug 646598 has been marked as a duplicate of this bug. ***
Comment 66 Jonathan Matthew 2011-07-24 23:16:13 UTC
*** Bug 649744 has been marked as a duplicate of this bug. ***
Comment 67 Mehmet Giritli 2013-01-10 21:35:14 UTC
For people who are interested to try out, I just finished improving+updating one of the plugins that has been lying around the web.

Highlights:

-Works with RB 2.98
-Updated to use dconf
-Uses gstreamer presets
-Added the ability to save/add/remove custom presets
-Ability to auto select a preset based on playing song's genre. Feature can be disabled from the configuration window.

Download here:
http://mehmet.giritli.eu/en/programming/
Comment 68 GNOME Infrastructure Team 2018-05-24 08:41:45 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/1.