After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797097 - Download gstreamer tarballs for releases instead of cloning the repo
Download gstreamer tarballs for releases instead of cloning the repo
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-09-07 16:37 UTC by Nirbheek Chauhan
Modified: 2018-09-11 14:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstreamer recipes: Centralize the source download logic (10.41 KB, patch)
2018-09-07 16:37 UTC, Nirbheek Chauhan 		committed Details | Review

Description Nirbheek Chauhan 2018-09-07 16:37:25 UTC 
This should make releases much faster to download and build for users, and should make it much easier to do releases as well, since now you only need to update the version in packages/custom.py and recipes/custom.py, and for a release tag, set tagged_for_release = True in recipes/custom.py.

After the release is tagged, set tagged_for_release = False and make a new commit. This will cause recipes to fetch the latest HEAD of the (stable) branch instead.
Comment 1 Nirbheek Chauhan 2018-09-07 16:37:30 UTC 
Created attachment 373559 [details] [review]
gstreamer recipes: Centralize the source download logic

Move the logic to custom.py, and toggle between origin/master,
origin/1.xy (stable branches) and tarballs based on the version and
the `tagged_for_release` property on the custom.GStreamer class.

Also replace self.name in git URLs similar to tarball URLs.

Now, the way to do releases is to set tagged_for_release = True, which
will force Cerbero to download tarballs instead of git repositories.
Comment 2 Nirbheek Chauhan 2018-09-07 16:41:16 UTC 
Another good reason to do this is to ensure that our generated tarballs have all the necessary files to build on all platforms.
Comment 3 Nicolas Dufresne (ndufresne) 2018-09-07 18:17:21 UTC 
Good Idea (haven't reviewed anything though). We should still eventually teach bundle_source to use git-archive for the other use cases.
Comment 4 Nicolas Dufresne (ndufresne) 2018-09-11 02:06:21 UTC 
Review of attachment 373559 [details] [review]:

Looks good to me.
Comment 5 Nirbheek Chauhan 2018-09-11 14:06:37 UTC 
Thanks for the review!

Attachment 373559 [details] pushed as cbf8115 - gstreamer recipes: Centralize the source download logic