After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795833 - Make Application.signal_window_(added|removed) take Window&, not Window*
Make Application.signal_window_(added|removed) take Window&, not Window*
Status: RESOLVED OBSOLETE
Product: gtkmm
Classification: Bindings
Component: general
3.93.x
Other All
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2018-05-05 12:45 UTC by Daniel Boles
Modified: 2018-05-22 12:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Daniel Boles 2018-05-05 12:45:39 UTC 
It's more C++ to pass a reference, unless the pointer has some semantic meaning (nullability, delete-when-done, etc.), none of which applies here: it would make no sense ever to emit either of these signals without giving the relevant Window.
Comment 1 Kjell Ahlstedt 2018-05-08 08:49:48 UTC 
I ran the commands
  grep '_WRAP_SIGNAL.*Window' gtk/src/*.hg
  grep '_WRAP_SIGNAL.*Container' gtk/src/*.hg
  grep '_WRAP_SIGNAL.*Widget' gtk/src/*.hg
and noticed that all the listed signal handlers take a pointer.
Comment 2 GNOME Infrastructure Team 2018-05-22 12:20:58 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtkmm/issues/34.