After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795319 - IM lookup position is different from other GTK applications
IM lookup position is different from other GTK applications
Status: RESOLVED OBSOLETE
Product: vte
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-17 08:28 UTC by Takao Fujiwara
Modified: 2021-06-10 15:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of IBus lookup window on VTE (15.06 KB, image/png)
2018-04-17 08:28 UTC, Takao Fujiwara
  Details
Patch of vte.cc (971 bytes, patch)
2018-04-17 08:29 UTC, Takao Fujiwara
none Details | Review
Patch of vte.cc (864 bytes, patch)
2018-06-01 04:26 UTC, Takao Fujiwara
none Details | Review

Description Takao Fujiwara 2018-04-17 08:28:15 UTC
Created attachment 371015 [details]
Screenshot of IBus lookup window on VTE

When IM lookup window is open on VTE, the position is always shifted with the width of pre-edit text. The position is different from the other GTK widgets likes GtkEntry, GtkText.
I can reproduce the problem with ibus-libpinyin and ibus-anthy.
Comment 1 Takao Fujiwara 2018-04-17 08:29:28 UTC
Created attachment 371016 [details] [review]
Patch of vte.cc

The candidate patch is attached.
Comment 2 Christian Persch 2018-04-17 11:35:54 UTC
Not sure that's right either. Shouldn't this instead change the get_preedit_width(false) to get_preedit_width(true) ?
Comment 3 Takao Fujiwara 2018-04-18 04:54:00 UTC
get_preedit_width(true) has a different behavior to other GTK widgets but probably I think it would be worthwhile.
I don't mind either using get_preedit_width(true) or deleting get_preedit_width(false).
Comment 4 Takao Fujiwara 2018-06-01 04:26:56 UTC
Created attachment 372499 [details] [review]
Patch of vte.cc

Hi, I updated the patch.
Could you integrate it?
Comment 5 Takao Fujiwara 2019-03-26 11:04:33 UTC
Do you have any chances to integrate the patch?
Comment 6 Christian Persch 2019-03-26 20:10:02 UTC
Comment on attachment 372499 [details] [review]
Patch of vte.cc

Please commit to master and gnome-3-32.
Comment 7 Takao Fujiwara 2019-03-28 04:30:24 UTC
Could you please commit the patch on behalf of me since I have the commit right?

I also looked at the gitlab merge request and seems vte does not have a contribution option of "Allow commits from members who can merge to the target branch":
https://gitlab.gnome.org/help/user/project/merge_requests/allow_collaboration
Comment 8 Takao Fujiwara 2019-03-28 04:31:05 UTC
(In reply to Takao Fujiwara from comment #7)
> Could you please commit the patch on behalf of me since I have the commit
> right?

Sorry, typo:
since I don't have the commit right.
Comment 9 GNOME Infrastructure Team 2021-06-10 15:31:27 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/vte/-/issues/2494.