After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795256 - dconf proxy credentials not used
dconf proxy credentials not used
Status: RESOLVED OBSOLETE
Product: libsoup
Classification: Core
Component: Misc
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2018-04-14 10:23 UTC by Jan-Michael Brummer
Modified: 2018-09-21 16:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proxy credential support (1.69 KB, patch)
2018-05-16 19:04 UTC, Jan-Michael Brummer
none Details | Review

Description Jan-Michael Brummer 2018-04-14 10:23:45 UTC
This is a request:

Currently every application that is in use behind a proxy server with authentication has to implement the callback to authenticate.

It would be nice if the already configured credentials within dconf /system/proxy/http would be taken into account. This would enable all libsoup based applications behind a corporate proxy without chaning any app.

Is this feasible?
Comment 1 Jan-Michael Brummer 2018-05-16 19:04:59 UTC
Created attachment 372130 [details] [review]
Proxy credential support

Attaching patch which adds system proxy credential usage if and only if it is a proxy auth request.

Please review.
Comment 2 Michael Catanzaro 2018-05-16 19:08:14 UTC
Review of attachment 372130 [details] [review]:

::: libsoup/soup-auth-manager.c
@@ +536,3 @@
+	/* Try to use system proxy credentials in case this is the first attempt to access the proxy */
+	if (soup_auth_is_for_proxy (auth) && !prior_auth_failed) {
+		GSettings *settings = g_settings_new ("org.gnome.system.proxy.http");

It will crash if gsettings-desktop-schemas is not installed. Not sure if libsoup already requires that or not.
Comment 3 GNOME Infrastructure Team 2018-09-21 16:34:52 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libsoup/issues/117.