After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794787 - Many fixes to the GObject introspection
Many fixes to the GObject introspection
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2018-03-28 23:07 UTC by Corentin Noël
Modified: 2018-08-06 13:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Many GObject introspection fixes (76.19 KB, patch)
2018-03-28 23:08 UTC, Corentin Noël
none Details | Review
SoupAuthDomain: assign right types to subclass methods and fix (6.97 KB, patch)
2018-04-06 13:32 UTC, Corentin Noël
none Details | Review
Do not include the header exclusion guards in the introspection (48.31 KB, patch)
2018-04-06 13:33 UTC, Corentin Noël
none Details | Review
SoupURI: make soup_uri_new_with_base a constructor (996 bytes, patch)
2018-04-06 13:34 UTC, Corentin Noël
none Details | Review
SoupProxyResolver: add this deprecated class to the introspection (4.69 KB, patch)
2018-04-06 13:35 UTC, Corentin Noël
none Details | Review
SoupProxyResolver: add this deprecated class to the introspection (5.27 KB, patch)
2018-04-17 10:59 UTC, Corentin Noël
none Details | Review

Description Corentin Noël 2018-03-28 23:07:49 UTC
Here is a patch,
Support for vala < 0.22 is removed as it's a very old version
Comment 1 Corentin Noël 2018-03-28 23:08:10 UTC
Created attachment 370271 [details] [review]
Many GObject introspection fixes
Comment 2 Claudio Saavedra 2018-03-29 08:50:12 UTC
Thanks for the patch. You'll have to split it into smaller patches each addressing a separate issue, in order to be able to review it properly.
Comment 3 Corentin Noël 2018-03-29 21:44:16 UTC
Yeah you're right, I was too happy to fix those issues.
Here is a first smaller one (using git branches) :
https://git.gnome.org/browse/libsoup/log/?h=wip/tintou/g-ir-no-header-guards
Comment 4 Corentin Noël 2018-03-29 22:58:38 UTC
Here is a set of branches:
https://git.gnome.org/browse/libsoup/log/?h=wip/tintou/uri-constructor
https://git.gnome.org/browse/libsoup/log/?h=wip/tintou/proxy-resolver
https://git.gnome.org/browse/libsoup/log/?h=wip/tintou/auth-domain

There are some remaining bits from the patch above but I'll provide them once the first patches have landed as there is a high probability of conflicts.
Comment 5 Corentin Noël 2018-03-29 23:00:22 UTC
btw: I messed-up with the prefix and pushed `tintou/wip/auth-domain` that can safely be removed (wrong prefix means that I can't do it myself :/ )
Comment 6 Claudio Saavedra 2018-04-06 13:23:33 UTC
Hm, you'll have to submit the patches here so that we can review them.
Comment 7 Corentin Noël 2018-04-06 13:32:55 UTC
Created attachment 370580 [details] [review]
SoupAuthDomain: assign right types to subclass methods and fix
Comment 8 Corentin Noël 2018-04-06 13:33:37 UTC
Created attachment 370581 [details] [review]
Do not include the header exclusion guards in the introspection
Comment 9 Corentin Noël 2018-04-06 13:34:48 UTC
Created attachment 370582 [details] [review]
SoupURI: make soup_uri_new_with_base a constructor
Comment 10 Corentin Noël 2018-04-06 13:35:47 UTC
Created attachment 370583 [details] [review]
SoupProxyResolver: add this deprecated class to the introspection
Comment 11 Corentin Noël 2018-04-06 13:36:29 UTC
Here are the patches, I'm looking forward the GitLab migration ;)
Comment 12 Tomas Popela 2018-04-16 05:55:43 UTC
(In reply to Corentin Noël from comment #10)
> Created attachment 370583 [details] [review] [review]
> SoupProxyResolver: add this deprecated class to the introspection

Would it be possible to rebase the patch and modify the Meson files as well?
Comment 13 Corentin Noël 2018-04-17 10:59:28 UTC
Created attachment 371030 [details] [review]
SoupProxyResolver: add this deprecated class to the introspection

Rebased patch against latest master and adapt meson.build accordingly
Comment 14 Claudio Saavedra 2018-08-03 14:33:47 UTC
I'm confused. I see these commits 3da8311f~1..dba29f88 in libsoup's master that I think are the patches here. Were they reviewed? By whom and where? If so, why are they still unreviewed here? If they have not been reviewed, why are they pushed to master?
Comment 15 Michael Catanzaro 2018-08-06 13:21:11 UTC
I rubber-stamped these after seeing the merge requests.

I didn't know about this bug: let's close it.