GNOME Bugzilla – Bug 794787
Many fixes to the GObject introspection
Last modified: 2018-08-06 13:21:11 UTC
Here is a patch, Support for vala < 0.22 is removed as it's a very old version
Created attachment 370271 [details] [review] Many GObject introspection fixes
Thanks for the patch. You'll have to split it into smaller patches each addressing a separate issue, in order to be able to review it properly.
Yeah you're right, I was too happy to fix those issues. Here is a first smaller one (using git branches) : https://git.gnome.org/browse/libsoup/log/?h=wip/tintou/g-ir-no-header-guards
Here is a set of branches: https://git.gnome.org/browse/libsoup/log/?h=wip/tintou/uri-constructor https://git.gnome.org/browse/libsoup/log/?h=wip/tintou/proxy-resolver https://git.gnome.org/browse/libsoup/log/?h=wip/tintou/auth-domain There are some remaining bits from the patch above but I'll provide them once the first patches have landed as there is a high probability of conflicts.
btw: I messed-up with the prefix and pushed `tintou/wip/auth-domain` that can safely be removed (wrong prefix means that I can't do it myself :/ )
Hm, you'll have to submit the patches here so that we can review them.
Created attachment 370580 [details] [review] SoupAuthDomain: assign right types to subclass methods and fix
Created attachment 370581 [details] [review] Do not include the header exclusion guards in the introspection
Created attachment 370582 [details] [review] SoupURI: make soup_uri_new_with_base a constructor
Created attachment 370583 [details] [review] SoupProxyResolver: add this deprecated class to the introspection
Here are the patches, I'm looking forward the GitLab migration ;)
(In reply to Corentin Noël from comment #10) > Created attachment 370583 [details] [review] [review] > SoupProxyResolver: add this deprecated class to the introspection Would it be possible to rebase the patch and modify the Meson files as well?
Created attachment 371030 [details] [review] SoupProxyResolver: add this deprecated class to the introspection Rebased patch against latest master and adapt meson.build accordingly
I'm confused. I see these commits 3da8311f~1..dba29f88 in libsoup's master that I think are the patches here. Were they reviewed? By whom and where? If so, why are they still unreviewed here? If they have not been reviewed, why are they pushed to master?
I rubber-stamped these after seeing the merge requests. I didn't know about this bug: let's close it.