After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793110 - rtspconnection: No Content-Type header in HTTP POST requests for RTSP tunnelling
rtspconnection: No Content-Type header in HTTP POST requests for RTSP tunnelling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-02 00:00 UTC by Sebastien Cote
Modified: 2018-02-08 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add the correct content-type to the HTTP POST request (743 bytes, patch)
2018-02-02 00:00 UTC, Sebastien Cote
none Details | Review

Description Sebastien Cote 2018-02-02 00:00:23 UTC
Created attachment 367781 [details] [review]
Add the correct content-type to the HTTP POST request

When the GstRTSPConnection class sends a RTSP over HTTP tunnelling request, the HTTP Content-Type header is missing from the HTTP POST request.

This isn't a problem with most servers, but I have access to a server that rejects the request.

Relevant specifications:

RFC 1945:
Any HTTP/1.0 message containing an entity body should include a Content-Type header field defining the media type of that body.

Apple Dispatch 28:
QuickTime Streaming uses the "application/x-rtsp-tunnelled" MIME type in both the Content-Type and Accept headers. This reflects the data type that is expected and delivered by the client and server.
Comment 1 Tim-Philipp Müller 2018-02-08 16:29:10 UTC
Thanks for the patch!

Next time it would be great if you could submit the patch in "git format-patch" format with author/data/commit message :)

commit 9e77d9cacf5960c54bb0a26688208d898b380ea0
Author: Sebastian Cote <sebas642@yahoo.ca>
Date:   Fri Feb 2 00:00:23 2018 +0000

    rtspconnection: also add Content-Type to HTTP POST request when tunnelling
    
    When the GstRTSPConnection class sends a RTSP over HTTP tunnelling
    request, the HTTP Content-Type header is missing from the HTTP POST
    request.
    
    This isn't a problem with most servers, but there are servers that
    rejects the request without there also being a Content-Type header.
    
    RFC 1945:
    Any HTTP/1.0 message containing an entity body should include a
    Content-Type header field defining the media type of that body.
    
    Apple Dispatch 28:
    QuickTime Streaming uses the "application/x-rtsp-tunnelled" MIME
    type in both the Content-Type and Accept headers. This reflects
    the data type that is expected and delivered by the client and server.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=793110