Created attachment 363707 [details] [review]
main: Remove GNOME_DESKTOP_SESSION_ID envvar

It was re-added "for compatibility reasons" nearly 10 years ago in
commit b7c806503. There's really no need to keep this compatibility any
longer.

Review of attachment 363707 [details] [review]:

one less environment variable sounds good to me.

Attachment 363707 [details] pushed as 6bf47ad - main: Remove GNOME_DESKTOP_SESSION_ID envvar

Created attachment 368276 [details] [review]
Revert "main: Remove GNOME_DESKTOP_SESSION_ID envvar"

This reverts commit 6bf47ad8c6f0a513c95a5043e38ad51cc0248943.

we can't do this, breaks libproxy which breaks gnome-shell:

https://github.com/libproxy/libproxy/blob/master/libproxy/modules/config_gnome3.cpp#L290

Comment on attachment 368276 [details] [review]
Revert "main: Remove GNOME_DESKTOP_SESSION_ID envvar"

committed the revert:
https://git.gnome.org/browse/gnome-session/commit/?id=5f920253dfb2c0f2c4b742690f306cfea2ac6613

(In reply to Ray Strode [halfline] from comment #5)
> we can't do this, breaks libproxy which breaks gnome-shell:

Should be half-fixed by https://git.gnome.org/browse/glib-networking/commit/?id=89c45b82b85daef0f1e679dbd15a9c7c893deb17, which will ensure that libproxy is not used by GNOME stuff (e.g. gnome-shell) when running inside GNOME. I *think* it should be safe to re-land the gnome-session commit now.

That doesn't fix the underlying problem in libproxy, which is that libproxy links to one version of mozjs, while gjs links to another version of mozjs, so the two are incompatible, and that glib will dlopening libproxy at runtime, but only when not running in GNOME to ensure developers don't notice.

Comment on attachment 363707 [details] [review]
main: Remove GNOME_DESKTOP_SESSION_ID envvar

Reset the patch status, as it's been reverted.

I'm guessing we can commit this once 3.28 has been branched?

yea i believe mcatanzaro fixed it at tge other end so we should be good

Attachment 363707 [details] pushed as 00e0e62 - main: Remove GNOME_DESKTOP_SESSION_ID envvar