GNOME Bugzilla – Bug 789002
Make the Git repositories and submodules work with Web proxies
Last modified: 2017-10-19 07:44:09 UTC
The repository's whose urls are like "git://..." are not getting cloned because the proxy server blocks such urls.
Created attachment 361596 [details] [review] Changed the git:// url to https:// ones in .gitmodules and flatpak/org.gnome.Photos.json
Review of attachment 361596 [details] [review]: Thanks for the patch! The commit message needs more work: (a) The From: field should have a valid "Full Name <email>". See the other commits in the repo and https://wiki.gnome.org/Newcomers/SubmitPatch (b) The commit message should have the URL of this bug. See the other commits in the repo and https://wiki.gnome.org/Newcomers/SubmitPatch (c) This commit doesn't just touch the Flatpak JSON, so the org.gnome.Photos.json prefix isn't quite right. Either use two separate patches or change the summary.
Created attachment 361669 [details] [review] Submitting two patches, this one is for .gitmodules.
Created attachment 361670 [details] [review] Changed the "git://..." urls in org.gnome.Photos.json to "https://..." ones
Review of attachment 361669 [details] [review]: Thanks for generating the patches with "git format-patch". However, (a) and (b) from comment 2 still apply.
Review of attachment 361670 [details] [review]: Ditto. (a) and (b) from comment 2 still apply.
Created attachment 361728 [details] [review] build: Make the Git submodules work with Web proxies I fixed and pushed this one. Could you try to fix the other patch?
Created attachment 361744 [details] [review] I generated this one using command line.
Review of attachment 361744 [details] [review]: Thanks, Saksham! Looks very good. A few nitpicky details: ::: flatpak/org.gnome.Photos.json @@ +90,3 @@ { "type": "git", + "url": "https://git.gnome.org/browse/gnome-online-accounts/" Nitpick: stray trailing forward slash. @@ +124,3 @@ { "type": "git", + "url": "https://git.gnome.org/browse/libgdata/" Ditto.
Created attachment 361842 [details] [review] flatpak: Make the Git repositories work with Web proxies Fixed and pushed! I hope you have an easier time building gnome-photos now.