After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788250 - gtkbuilder: wrong usage of gtk_buildable_custom_tag_end
gtkbuilder: wrong usage of gtk_buildable_custom_tag_end
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Class: GtkBuilder
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: GtkBuilder maintainers
GtkBuilder maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-27 16:28 UTC by Nubosch
Modified: 2018-05-02 19:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Nubosch 2017-09-27 16:28:39 UTC 
gtk_buildable_custom_tag_end [1] expects to get called with gpointer*
but gets passed data->subparser->data [2] from subparser_end() which is defined as gpointer [3]. 

fixing this in either direction may break existing users in interesting ways but I would expect the interface definition to be respected.

[1]
https://git.gnome.org/browse/gtk+/tree/gtk/gtkbuildable.h#n114

[2]
https://git.gnome.org/browse/gtk+/tree/gtk/gtkbuilderparser.c#n846

[3]
https://git.gnome.org/browse/gtk+/tree/gtk/gtkbuilderprivate.h#n95
Comment 1 Matthias Clasen 2017-10-04 01:37:00 UTC 
Looking at uses inside gtk, the extra indirection always gets cast away.

We should probably fix this in master, and maybe better not touch it in 3.22
Comment 2 Nubosch 2017-10-11 09:10:18 UTC 
Yes, doing this in master seems reasonable. I still would prefer to pass &data->subparser->data or data ends up as dangling pointer. I'm fine with fixing it the other way around if you think it is not worth the trouble.
Comment 3 GNOME Infrastructure Team 2018-05-02 19:09:13 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/921.