After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786984 - sharing: Make panel initialization asynchronous
sharing: Make panel initialization asynchronous
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sharing
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-29 16:12 UTC by Rui Matos
Modified: 2017-08-29 17:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sharing: Make panel initialization asynchronous (8.44 KB, patch)
2017-08-29 16:12 UTC, Rui Matos
committed Details | Review
sharing: Remove an unused variable (995 bytes, patch)
2017-08-29 16:12 UTC, Rui Matos
committed Details | Review
sharing: Make use of the cancellable for async hostname calls (1.53 KB, patch)
2017-08-29 16:12 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2017-08-29 16:12:20 UTC
See patches.
Comment 1 Rui Matos 2017-08-29 16:12:24 UTC
Created attachment 358702 [details] [review]
sharing: Make panel initialization asynchronous
Comment 2 Rui Matos 2017-08-29 16:12:30 UTC
Created attachment 358703 [details] [review]
sharing: Remove an unused variable
Comment 3 Rui Matos 2017-08-29 16:12:35 UTC
Created attachment 358704 [details] [review]
sharing: Make use of the cancellable for async hostname calls

We have it initialized and disposed and the async calls already handle
being cancelled. We just forgot to actually use it.
Comment 4 Rui Matos 2017-08-29 17:30:23 UTC
Attachment 358702 [details] pushed as f959b91 - sharing: Make panel initialization asynchronous
Attachment 358703 [details] pushed as 94045b8 - sharing: Remove an unused variable
Attachment 358704 [details] pushed as 2556fd5 - sharing: Make use of the cancellable for async hostname calls