After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786874 - Layer picking tools
Layer picking tools
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: Tools
git master
Other All
: Normal enhancement
: 3.0
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2017-08-27 21:39 UTC by Mike Bjorkegren
Modified: 2018-05-24 18:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
zip with 3 patches based on 0ef3795f0a294d97cbeb4fe0faf4c6a5e83e387e (14.99 KB, application/x-zip-compressed)
2017-08-27 21:39 UTC, Mike Bjorkegren
  Details
Pick Tool for layers and paths (24.77 KB, patch)
2017-12-22 08:12 UTC, Michael Schumacher
none Details | Review
Swap hotkeys for pick tool align tool (1.46 KB, patch)
2017-12-22 08:12 UTC, Michael Schumacher
none Details | Review
Add ability to disable picking of specified layers (45.70 KB, patch)
2017-12-22 08:13 UTC, Michael Schumacher
none Details | Review

Description Mike Bjorkegren 2017-08-27 21:39:36 UTC
Created attachment 358536 [details]
zip with 3 patches based on 0ef3795f0a294d97cbeb4fe0faf4c6a5e83e387e

This includes two features related to picking layers.

1. A dedicated layer picking tool that basically copies the picking functionality of the Move tool.

2. A per-layer toggle that allows the user to disable picking for that layer. This makes it easier to pick objects under large semi-transparent layers.

I've split it into three patches, one dedicated to setting the hotkey for the pick tool to 'Q', which was already used by the Align tool. I'm not sure what the policy is on switching hotkeys, so I left that as a separate commit. The reason for choosing 'Q' is that both the Unity game engine editor and Autodesk Maya use Q for the select tool. I found that Shift-A was available, and that seems like it might actually be better than Q for the align tool.
Comment 1 Jehan 2017-12-22 00:24:04 UTC
I won't look at these huge patches before 2.10 because we must stop adding new features. But I am setting it for a 3.0 milestone so that to remind myself to review it as soon as GIMP 2.10 is released.
There are patches, we must not let them bitrot!

By the way, next time, please upload the patches separately as patches (that means making 2 more comments after your description, which is boring, yet). This way, first it will be much quicklier noticed, second we will benefit from review GUI.
Thanks for the patches!
Comment 2 Michael Schumacher 2017-12-22 08:12:26 UTC
Created attachment 365872 [details] [review]
Pick Tool for layers and paths
Comment 3 Michael Schumacher 2017-12-22 08:12:54 UTC
Created attachment 365874 [details] [review]
Swap hotkeys for pick tool align tool
Comment 4 Michael Schumacher 2017-12-22 08:13:15 UTC
Created attachment 365875 [details] [review]
Add ability to disable picking of specified layers
Comment 5 Michael Schumacher 2017-12-22 08:13:58 UTC
Let's make those patches easier to examine and review (and appear in the Bugzilla reports)
Comment 6 GNOME Infrastructure Team 2018-05-24 18:21:59 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/1178.